Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication.oidc feature flag #7174

Closed
creydr opened this issue Aug 15, 2023 · 6 comments · Fixed by #7183
Closed

Add authentication.oidc feature flag #7174

creydr opened this issue Aug 15, 2023 · 6 comments · Fixed by #7183
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Aug 15, 2023

Problem

As the Eventing OIDC feature track describes, the feature track leverages a new config-features configuration called authentication.oidc.

We should add:

Time Estimate (optional)

1

Additional context (optional)

/good-first-issue

@creydr creydr added the kind/TBD Parked issue that required triaging/revisit in a near future. label Aug 15, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 15, 2023

@creydr:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Problem

As the Eventing OIDC feature track describes, the feature track leverages a new config-features configuration called authentication.oidc.

We should add:

Time Estimate (optional)

1

Additional context (optional)

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 15, 2023
@karthikmurali60
Copy link
Contributor

@creydr can i work on this issue? I'd love to contribute !

@creydr
Copy link
Member Author

creydr commented Aug 16, 2023

Welcome to Knative @karthikmurali60 🎉 👋
Glad to hear you want to contribute. I am currently creating the tasks for the OIDC implementation in Knative Eventing.
Just a side note: Not all of the created issues might contain all the needed information right now or might be reworked and need to be triaged (that's the reason why I marked them as DRAFT or added the kind/TBD label). But this issue looks fine I guess.

@karthikmurali60
Copy link
Contributor

Thanks for the information @creydr !!
Happy to be contributing to Knative

@creydr creydr changed the title [DRAFT] Add authentication.oidc feature flag Add authentication.oidc feature flag Aug 17, 2023
@creydr creydr removed the kind/TBD Parked issue that required triaging/revisit in a near future. label Sep 5, 2023
@Priyansurout
Copy link

can we do this for A helper method like func (e Flags) IsOIDCAuthentication() bool that would verify the authentication.oidc feature flag is enabled.```
package feature

const (
KReferenceGroup = "kreference-group"
DeliveryRetryAfter = "delivery-retryafter"
DeliveryTimeout = "delivery-timeout"
KReferenceMapping = "kreference-mapping"
NewTriggerFilters = "new-trigger-filters"
TransportEncryption = "transport-encryption"
EvenTypeAutoCreate = "eventtype-auto-create"
OIDCAuthentication = "authentication.oidc"
)

// Flags represents a set of feature flags.
type Flags map[string]bool

// IsOIDCAuthentication checks if the "authentication.oidc" feature flag is enabled.
func (f Flags) IsOIDCAuthentication() bool {
return f[OIDCAuthentication]
}

@creydr
Copy link
Member Author

creydr commented Sep 8, 2023

Hello @Priyansurout,
this issue is done already (status Closed). You can check how @karthikmurali60 implemented it in #7183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants