Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exposing the Audience of a Channel #7230

Closed
creydr opened this issue Sep 5, 2023 · 2 comments
Closed

Support exposing the Audience of a Channel #7230

creydr opened this issue Sep 5, 2023 · 2 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Sep 5, 2023

As the Eventing OIDC feature track describes, Addressables (and thus Channels) need to announce their audience in .status.address.audience in the format GROUP/KIND/NAMESPACE/NAME (e.g. messaging.knative.dev/channel/myns/mychannel).

In particular the channel controller should:

Additional Information:

@creydr creydr added kind/TBD Parked issue that required triaging/revisit in a near future. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed kind/TBD Parked issue that required triaging/revisit in a near future. labels Sep 5, 2023
@vishal-chdhry
Copy link
Member

/assign

@vishal-chdhry
Copy link
Member

I think the address should be set then from the IMC controller with the correct audience. Because when we set it in the channel reconciler, it will overwrite the value set from the IMC (or vice versa).

/cc @pierDipi @creydr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants