Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using underlying input channels audience as Sequences audience #7294

Closed
creydr opened this issue Sep 25, 2023 · 2 comments · Fixed by #7387
Closed

Support using underlying input channels audience as Sequences audience #7294

creydr opened this issue Sep 25, 2023 · 2 comments · Fixed by #7387
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Sep 25, 2023

As the Eventing OIDC feature track describes, Addressables (and thus Sequences) need to announce their audience in .status.address.audience. As an implementation detail, a Sequences address points to a Channel (which is an Addressable too and thus has an Audience). Therefor an Sequences audience should be equals to its input channels Audience.

In particular the Sequence controller should:

  • Set the Sequences Audience (.status.address.audience) to the same value as its input channels Audience (.status.address.audience)

Additional Information:

@creydr creydr added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 25, 2023
@md-saif-husain
Copy link
Contributor

/assign

@creydr
Copy link
Member Author

creydr commented Oct 18, 2023

Hello @md-saif-husain,
as #7187 is done, this should be ready to be worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants