Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support exposing the Audience of an InMemoryChannel #7187

Closed
creydr opened this issue Aug 16, 2023 · 8 comments · Fixed by #7371
Closed

Support exposing the Audience of an InMemoryChannel #7187

creydr opened this issue Aug 16, 2023 · 8 comments · Fixed by #7371
Assignees
@creydr
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Aug 16, 2023 •
edited
Loading

As the Eventing OIDC feature track describes, Addressables (and thus InMemoryChannels) need to announce their audience in .status.address.audience in the format GROUP/KIND/NAMESPACE/NAME (e.g. messaging.knative.dev/inmemorychannel/myns/myimc).

In particular the IMC controller should:

Additional Information:
@creydr creydr added kind/TBD Parked issue that required triaging/revisit in a near future. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 16, 2023
@creydr creydr mentioned this issue Aug 17, 2023
Closed
@creydr creydr changed the title [DRAFT] Support exposing the Audience of an InMemoryChannel Support exposing the Audience of an InMemoryChannel Sep 5, 2023
@creydr creydr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed kind/TBD Parked issue that required triaging/revisit in a near future. labels Sep 5, 2023
@CodesbyUnnati
Copy link

/assign

This was referenced Sep 25, 2023
Closed
Closed
Closed
@rahulii
Copy link
Contributor

rahulii commented Oct 2, 2023 •
edited
Loading

Hey @CodesbyUnnati , LMK if I can pick this up?

Thanks!

@creydr
Copy link
Member Author

creydr commented Oct 4, 2023

Hello @CodesbyUnnati,
can you give a rough ETA for a PR for this issue?

@CodesbyUnnati
Copy link

Hi @rahulii You can go ahead and pick this issue.

@rahulii
Copy link
Contributor

rahulii commented Oct 4, 2023

/assign

@creydr
Copy link
Member Author

creydr commented Oct 13, 2023 •
edited
Loading

@rahulii can you give a rough ETA for a PR, because #7294 and #7295 is blocked on this.

@rahulii
Copy link
Contributor

rahulii commented Oct 13, 2023

Starting on this right away!

@creydr creydr mentioned this issue Oct 16, 2023
Merged
@creydr
Copy link
Member Author

creydr commented Oct 16, 2023 •
edited
Loading

@rahulii I have #7371 to (hopefully) unblock the dependent issues

/assign

@creydr creydr mentioned this issue Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creydr creydr

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Eventing Sender Identity
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose audience of an InMemoryChannel in its status creydr/knative-eventing
3 participants
@creydr @rahulii @CodesbyUnnati