provision sequence audience using channel audience

[md-saif-husain]

Fixes #7294

Proposed Changes

• Use channel audience in sequence status.Address.Audience

Release Note

Use underlying input channels audience as sequence audience

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: md-saif-husain / name: MD SAIF HUSAIN (0e94869, 3c8f878, 3aab74e, feba9fb, 19d6675, 40f98ae, f4c087e)

[knative-prow]

Welcome @md-saif-husain! It looks like this is your first PR to knative/eventing 🎉

[knative-prow]

Hi @md-saif-husain. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[creydr]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ebe869) 76.74% compared to head (f4c087e) 76.79%.
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7387      +/-   ##
==========================================
+ Coverage   76.74%   76.79%   +0.04%     
==========================================
  Files         253      253              
  Lines       13916    14098     +182     
==========================================
+ Hits        10680    10826     +146     
- Misses       2702     2732      +30     
- Partials      534      540       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[creydr]

Thanks @md-saif-husain for your PR.
Looks good so far. Only left a small comment. Could you also add an e2e test for it?
You can check on

eventing/test/auth/oidc_test.go

Lines 58 to 74 in 392b535

	func TestChannelImplSupportsOIDC(t *testing.T) {
	t.Parallel()
	ctx, env := global.Environment(
	knative.WithKnativeNamespace(system.Namespace()),
	knative.WithLoggingConfig,
	knative.WithTracingConfig,
	k8s.WithEventListener,
	environment.Managed(t),
	environment.WithPollTimings(4*time.Second, 12*time.Minute),
	)
	name := feature.MakeRandomK8sName("channelimpl")
	env.Prerequisite(ctx, t, channel.ImplGoesReady(name))
	env.Test(ctx, t, oidc.AddressableHasAudiencePopulated(channel_impl.GVR(), channel_impl.GVK().Kind, name, env.Namespace()))
	}

how this was done for a channel

[md-saif-husain]

Thanks @md-saif-husain for your PR. Looks good so far. Only left a small comment. Could you also add an e2e test for it? You can check on

eventing/test/auth/oidc_test.go

Lines 58 to 74 in 392b535

	func TestChannelImplSupportsOIDC(t *testing.T) {
	t.Parallel()
	ctx, env := global.Environment(
	knative.WithKnativeNamespace(system.Namespace()),
	knative.WithLoggingConfig,
	knative.WithTracingConfig,
	k8s.WithEventListener,
	environment.Managed(t),
	environment.WithPollTimings(4*time.Second, 12*time.Minute),
	)
	name := feature.MakeRandomK8sName("channelimpl")
	env.Prerequisite(ctx, t, channel.ImplGoesReady(name))
	env.Test(ctx, t, oidc.AddressableHasAudiencePopulated(channel_impl.GVR(), channel_impl.GVK().Kind, name, env.Namespace()))
	}

how this was done for a channel

Sure I will add e2e test . Let me know if I can add them in same file as above or it should be new file

[creydr]

Sure I will add e2e test . Let me know if I can add them in same file as above or it should be new file

Same file should be fine here.

[md-saif-husain]

/retest

[creydr]

Suggested change

	env.Test(ctx, t, oidc.SequenceHasAudienceOfInputChannel(sequence.GVR(), sequence.GVK().Kind, name, env.Namespace()))
	env.Test(ctx, t, oidc.SequenceHasAudienceOfInputChannel(name, env.Namespace(), channel_impl.GVR(), channel_impl.GVK().Kind))

SequenceHasAudienceOfInputChannel has different parameters:

eventing/test/auth/features/oidc/sequence.go

Line 29 in 1757203

func SequenceHasAudienceOfInputChannel(sequenceName, sequenceNamespace string, channelGVR schema.GroupVersionResource, channelKind string) *feature.Feature {

Should fix the build issues:

# knative.dev/eventing/test/auth [knative.dev/eventing/test/auth.test]
test/auth/oidc_test.go:118:58: cannot use sequence.GVR() (value of type "k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource) as string value in argument to oidc.SequenceHasAudienceOfInputChannel
test/auth/oidc_test.go:118:95: cannot use name (variable of type string) as "k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource value in argument to oidc.SequenceHasAudienceOfInputChannel

[creydr]

Thanks a lot for you contribution @md-saif-husain

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, md-saif-husain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment