Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconciler for EventPolicy #7973

Closed
creydr opened this issue Jun 10, 2024 · 4 comments · Fixed by #8024
Closed

Add reconciler for EventPolicy #7973

creydr opened this issue Jun 10, 2024 · 4 comments · Fixed by #8024
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Jun 10, 2024

We need to add a reconciler for EventPolicies to update their status correctly. It should do the following:

  • Resolve references / set EventPolicies .status.from (subs)
  • Set .status.conditions:
    • AuthenticationEnabled to true if OIDC is enabled (Add authentication.oidc feature flag #7174) (and add watcher on feature flag configmap to update EventPolicies status if OIDC enabled/disabled)
    • SubjectsResolved to true if references are resolved
    • Ready, if the above are true

Prerequisites:

Additional context:

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.

Open points:

  • how to watch "all" references to get updates if they (/their .status.auth) changes?
@creydr creydr added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 10, 2024
@dharmjit
Copy link
Contributor

Hi @creydr, If okay, I can take this up.

@creydr
Copy link
Member Author

creydr commented Jun 12, 2024

Hey @dharmjit,
sure. Would be great! Simply assign it to you. Only note, that not all other issues which are a prerequisite for this are done yet.

@dharmjit
Copy link
Contributor

/assign

@creydr creydr added the triage/accepted Issues which should be fixed (post-triage) label Jun 13, 2024
@creydr
Copy link
Member Author

creydr commented Jun 18, 2024

Hey @dharmjit,
as the prerequisite issues are resolved, this should be ready to be worked on (moved from "Backlog" to "Ready").

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants