Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List applying policies in InMemoryChannels status #8011

Merged
merged 13 commits into from
Jun 20, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 18, 2024

Fixes #7977

Proposed Changes

  • 🎁 List EventPolicies in the InMemoryChannels .status.policies, which apply for it
  • 🎁 Add the EventPoliciesReady condition to indicate, if the referenced policies are Ready

Release Note

List applying EventPolicies in InMemoryChannels status

/hold
until we have #7973, as otherwise the IMCs would not become ready (as the EP stays NotReady)

@creydr creydr requested a review from pierDipi June 18, 2024 11:37
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
Copy link

knative-prow bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from aliok June 18, 2024 11:37
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 74.30168% with 46 lines in your changes missing coverage. Please review.

Project coverage is 67.79%. Comparing base (e298f32) to head (7519033).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/auth/event_policy.go 73.17% 11 Missing and 11 partials ⚠️
pkg/reconciler/testing/v1/eventpolicy.go 62.50% 15 Missing ⚠️
...g/apis/messaging/v1/in_memory_channel_lifecycle.go 25.00% 6 Missing ⚠️
...iler/inmemorychannel/controller/inmemorychannel.go 87.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8011      +/-   ##
==========================================
+ Coverage   67.74%   67.79%   +0.04%     
==========================================
  Files         362      363       +1     
  Lines       16714    16899     +185     
==========================================
+ Hits        11323    11456     +133     
- Misses       4695     4735      +40     
- Partials      696      708      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member Author

creydr commented Jun 18, 2024

/cc @pierDipi @converge
Even we need #7973 for this, it would be great to get already some reviews on this, so similar tasks could check on this too

@knative-prow knative-prow bot requested a review from converge June 18, 2024 12:24
@creydr creydr force-pushed the list-applying-policies-in-imc branch from 882beee to 039a5b9 Compare June 19, 2024 08:37
@creydr creydr force-pushed the list-applying-policies-in-imc branch from 039a5b9 to 999f4fc Compare June 19, 2024 08:38
pkg/reconciler/eventpolicy.go Outdated Show resolved Hide resolved
pkg/reconciler/eventpolicy.go Outdated Show resolved Hide resolved
pkg/reconciler/eventpolicy.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 20, 2024
@creydr creydr force-pushed the list-applying-policies-in-imc branch from 86885c3 to a1e0b72 Compare June 20, 2024 10:01
@creydr creydr requested a review from pierDipi June 20, 2024 12:04
@creydr
Copy link
Member Author

creydr commented Jun 20, 2024

/hold cancel
as we don't need to wait for #7973 (IMC will stay Ready, as long as not matching EP exist)

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@creydr
Copy link
Member Author

creydr commented Jun 20, 2024

wait.go:200: test-fqpoqcmm/sinkbinding-jvibghuz condition is {"type":"Ready","status":"False","lastTransitionTime":"2024-06-20T14:45:01Z","reason":"TrustBundlePropagation","message":"failed to update ConfigMap test-fqpoqcmm/knative-eventing-bundlekne-bundle: Operation cannot be fulfilled on configmaps \"knative-eventing-bundlekne-bundle\": the object has been modified; please apply your changes to the latest version and try again"}

/test reconciler-tests

@pierDipi
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@knative-prow knative-prow bot merged commit f4df40f into knative:main Jun 20, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List applying policies in InMemoryChannel .status.policies
2 participants