Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List applying policies in Channel and propagate EventPolicies to underlying channel #8014

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 19, 2024

Fixes #8013

Proposed Changes

  • 🎁 List EventPolicies in the channels .status.policies, which apply for it
  • 🎁 Add the EventPoliciesReady condition to indicate, if the referenced policies are Ready
  • 🎁 Create a copy of the EventPolicies applying for the Channel, to target the backing channel

Release Note

List applying EventPolicies in Channels status and propagate EventPolicies to backing channel

@creydr creydr requested a review from pierDipi June 19, 2024 14:07
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 19, 2024
Copy link

knative-prow bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo June 19, 2024 14:07
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 58.10056% with 75 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (f4df40f) to head (1373264).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/reconciler/channel/channel.go 46.15% 17 Missing and 11 partials ⚠️
pkg/auth/event_policy.go 0.00% 26 Missing ⚠️
pkg/reconciler/testing/v1/eventpolicy.go 47.05% 9 Missing ⚠️
pkg/apis/messaging/v1/channel_lifecycle.go 50.00% 4 Missing ⚠️
pkg/reconciler/channel/controller.go 77.77% 2 Missing and 2 partials ⚠️
pkg/reconciler/testing/v1/channel.go 84.21% 3 Missing ⚠️
...iler/inmemorychannel/controller/inmemorychannel.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8014      +/-   ##
==========================================
- Coverage   67.79%   67.70%   -0.09%     
==========================================
  Files         363      364       +1     
  Lines       16899    17042     +143     
==========================================
+ Hits        11456    11538      +82     
- Misses       4735     4783      +48     
- Partials      708      721      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr force-pushed the channel-list-applying-policies-and-propagate-eps-to-underlying-channel-implementation branch from 0c70a8c to 9efc3c7 Compare June 21, 2024 10:13
@creydr creydr changed the title [WIP] List applying policies in Channel and propagate EventPolicies to underlying channel List applying policies in Channel and propagate EventPolicies to underlying channel Jun 21, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2024
@creydr creydr requested a review from pierDipi June 21, 2024 10:49
@creydr
Copy link
Member Author

creydr commented Jun 21, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
@creydr
Copy link
Member Author

creydr commented Jun 24, 2024

@pierDipi could you recheck?

@creydr creydr force-pushed the channel-list-applying-policies-and-propagate-eps-to-underlying-channel-implementation branch from 9efc3c7 to c1e5b2f Compare June 24, 2024 10:14
@creydr creydr force-pushed the channel-list-applying-policies-and-propagate-eps-to-underlying-channel-implementation branch from c1e5b2f to 1373264 Compare June 24, 2024 10:49
@creydr creydr requested a review from pierDipi June 24, 2024 10:49
@pierDipi
Copy link
Member

/lgtm

@pierDipi
Copy link
Member

/test reconciler-tests

@knative-prow knative-prow bot merged commit d4e647d into knative:main Jun 24, 2024
29 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
2 participants