Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List applying policies in Channel .status.policies and propagate applying EventPolicies to the underlying channel #8013

Closed
creydr opened this issue Jun 19, 2024 · 0 comments · Fixed by #8014
Assignees
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Jun 19, 2024

As the Eventing Authorization feature track describes, target resources of EventPolicies, will reflect in their status, which EventPolicy is applied to them.

For example:

apiVersion: messaging.knative.dev/v1
kind: Channel
metadata:
  name: my-channel
spec:
  ...
status:
  ...
  policies:
    - name: event-policy
      apiVersion: v1alpha1
    - name: another-event-policy
      apiVersion: v1alpha1

  conditions:
    - type: Ready
      status: "True"
    - type: EventPoliciesReady
      status: "True"

As Channels should support EventPolicies, wee need to do the following:

  • Update the Channel reconciler to list the applying policies in the Channels .status.policies and set the channels EventPoliciesReady condition. Also watch EventPolicies for changes.
  • Set EventPoliciesReady condition to true, in case no policy applies, and set message according to the default-authorization-mode (e.g. Default authorization mode is 'allow-all'). Check the Default Authorization Mode section in the feature track for additional information.
  • Copy the EventPolicies which apply for the Channel down to the underlying channel, so that EventPolicies which apply for the Channel also apply for the underlying channel.

Prerequisites:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
1 participant