Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List applying policies in mt-brokers .status.policies #7976

Closed
creydr opened this issue Jun 10, 2024 · 8 comments · Fixed by #8060
Closed

List applying policies in mt-brokers .status.policies #7976

creydr opened this issue Jun 10, 2024 · 8 comments · Fixed by #8060
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Jun 10, 2024

As the Eventing Authorization feature track describes, target resources of EventPolicies, will reflect in their status, which EventPolicy is applied to them.

For example:

apiVersion: eventing.knative.dev/v1
kind: Broker
metadata:
  name: my-broker
spec:
  ...
status:
  ...
  policies:
    - name: event-policy
      apiVersion: v1alpha1
    - name: another-event-policy
      apiVersion: v1alpha1

  conditions:
    - type: Ready
      status: "True"
    - type: EventPoliciesReady
      status: "True"

As the mt-broker should support EventPolicies, wee need to do the following:

  • Update the Broker reconciler to show applying policies in the Brokers .status.policies and set the Brokers EventPoliciesReady condition. Also watch EventPolicies for changes.
  • Set EventPoliciesReady condition to true, in case no policy applies, and set message according to the default-authorization-mode (e.g. Default authorization mode is 'allow-all'). Check the Default Authorization Mode section in the feature track for additional information.

Hint:

Prerequisites:

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
@creydr creydr added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 10, 2024
@creydr creydr added the triage/accepted Issues which should be fixed (post-triage) label Jun 13, 2024
@asr2003
Copy link

asr2003 commented Jun 13, 2024

/assign

@EraKin575
Copy link
Contributor

@asr2003 are you still working on this issue?

@creydr
Copy link
Member Author

creydr commented Jun 17, 2024

@asr2003 are you still working on this issue?

@EraKin575, this issue is still in status "Backlog", as not all the dependent issues (e.g. #7985 (which should be done soon)) are resolved yet. So @asr2003 didn't have a chance to work on it yet.

@asr2003
Copy link

asr2003 commented Jun 17, 2024 via email

@creydr
Copy link
Member Author

creydr commented Jun 24, 2024

Hey @asr2003,
This issue is ready to be worked on. You can also check on #8014, how we solved this for the Channel (particularly on b7ff773 and 7891138).
Please let us know if you have any questions :)

@asr2003
Copy link

asr2003 commented Jun 24, 2024 via email

@creydr
Copy link
Member Author

creydr commented Jun 28, 2024

Hello @asr2003,
Good luck with your exams 🤞
As this issue in in iteration 2 which ends next week (July 6th), please let us know if you'll be able to finish it till then (please also count some time for review cycles).
Please don't feel stressed about it with your exams and feel free to otherwise unassign yourself, so that another contributor could pick this up.

@asr2003
Copy link

asr2003 commented Jun 28, 2024

@creydr Will unassign this and will reassign if any other contributor not pickup the issue till my exams are done

@asr2003 asr2003 removed their assignment Jun 28, 2024
@creydr creydr self-assigned this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants