Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mt-broker-reconciler: Create EventPolicies for mt-broker #7982

Closed
creydr opened this issue Jun 10, 2024 · 2 comments · Fixed by #8090
Closed

mt-broker-reconciler: Create EventPolicies for mt-broker #7982

creydr opened this issue Jun 10, 2024 · 2 comments · Fixed by #8090
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Jun 10, 2024

As the mt-broker implementation uses Channels under the hood, we need to make sure we have the correct EventPolicies in place to not block requests to the underlying channel. Therefor the mt-broker reconciler should behave as described:

  • In case the authentication-oidc feature flag is set to enabled:
    • create an EventPolicy for the event flow from mt-broker-ingress to the underlying Channel, with the following properties:
      • .spec.ref: pointing to the channel
      • .spec.from: sub from the mt-broker-ingress (system:serviceaccount:knative-eventing:mt-broker-ingress-oidc as defined in ingress_handler.go#L324)
      • owner reference of EventPolicy points to the Broker, so that we have a lifecycle binding
  • In case the authentication-oidc feature flag is set to disabled:
    • clean up eventually existing EventPolicies which were created when authentication-oidc was enabled (e.g. by filtering on EventPolicies which have an owner reference to an mt-broker)

Prerequisites:

Additional context:

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
@creydr creydr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage) labels Jun 10, 2024
@rahulii
Copy link
Contributor

rahulii commented Jun 14, 2024

/assign

@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 9, 2024

Hey @rahulii , anything I can help you with on this?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants