Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List applying EventPolicies in Brokers status #8060

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Jul 1, 2024

Fixes #7976

Proposed Changes

  • 🎁 List EventPolicies in the Brokers .status.policies, which apply for it
  • 🎁 Add the EventPoliciesReady condition to indicate, if the referenced policies are Ready

Release Note

List applying EventPolicies in Brokers status

@creydr creydr requested review from pierDipi and Leo6Leo July 1, 2024 10:05
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2024
@knative-prow knative-prow bot requested a review from aliok July 1, 2024 10:05
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.93%. Comparing base (3b1bfb4) to head (73599d4).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/apis/eventing/v1/broker_lifecycle.go 50.00% 4 Missing ⚠️
pkg/reconciler/broker/broker.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8060      +/-   ##
==========================================
+ Coverage   67.89%   67.93%   +0.03%     
==========================================
  Files         366      366              
  Lines       17115    17151      +36     
==========================================
+ Hits        11621    11651      +30     
- Misses       4773     4778       +5     
- Partials      721      722       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulii
Copy link
Contributor

rahulii commented Jul 1, 2024

Looking good 👍🏼

@creydr
Copy link
Member Author

creydr commented Jul 3, 2024

@Leo6Leo could you PTAL?

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
Copy link

knative-prow bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3264b21 into knative:main Jul 4, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List applying policies in mt-brokers .status.policies
3 participants