Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List applying policies in InMemoryChannel .status.policies #7977

Closed
creydr opened this issue Jun 10, 2024 · 5 comments · Fixed by #8011
Closed

List applying policies in InMemoryChannel .status.policies #7977

creydr opened this issue Jun 10, 2024 · 5 comments · Fixed by #8011
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Member

creydr commented Jun 10, 2024

As the Eventing Authorization feature track describes, target resources of EventPolicies, will reflect in their status, which EventPolicy is applied to them.

For example:

apiVersion: messaging.knative.dev/v1
kind: InMemoryChannel
metadata:
  name: my-imc
spec:
  ...
status:
  ...
  policies:
    - name: event-policy
      apiVersion: v1alpha1
    - name: another-event-policy
      apiVersion: v1alpha1

  conditions:
    - type: Ready
      status: "True"
    - type: EventPoliciesReady
      status: "True"

As the InMemoryChannel should support EventPolicies, wee need to do the following:

  • Update the InMemoryChannel reconciler to show applying policies in the InMemoryChannels .status.policies and set the InMemoryChannels EventPoliciesReady condition. Also watch EventPolicies for changes.
  • Set EventPoliciesReady condition to true, in case no policy applies, and set message according to the default-authorization-mode (e.g. Default authorization mode is 'allow-all'). Check the Default Authorization Mode section in the feature track for additional information.

Hint:

Prerequisites:

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
@creydr creydr added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 10, 2024
@creydr creydr added the triage/accepted Issues which should be fixed (post-triage) label Jun 13, 2024
@creydr creydr self-assigned this Jun 13, 2024
@EraKin575
Copy link
Contributor

I would like to work on this issue!

@EraKin575
Copy link
Contributor

/assign

@creydr
Copy link
Member Author

creydr commented Jun 17, 2024

Hey @EraKin575,
This issue is already assigned. You can always check on the "Assignees" field to see, it somebody already assigned this issue

@EraKin575
Copy link
Contributor

my bad, I thought it was open to new contributors

@creydr
Copy link
Member Author

creydr commented Jun 17, 2024

my bad, I thought it was open to new contributors

No worries. I'll probably have to create some new issues in the next days (e.g. related to some e2e tests). Maybe you'll find then some good issues for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants