Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC Authentication feature flag #7183

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

karthikmurali60
Copy link
Contributor

Fixes #7174

Proposed Changes

  • 🎁 Add OIDC Authentication flag

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

Signed-off-by: karthikmurali60 <karthik.murali60@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 16, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: karthikmurali60 / name: Karthik Muraliprasad (befc053)

@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

Welcome @karthikmurali60! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2023
@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

Hi @karthikmurali60. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member

creydr commented Aug 16, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (29ac3ee) 77.93% compared to head (befc053) 77.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7183      +/-   ##
==========================================
+ Coverage   77.93%   77.95%   +0.01%     
==========================================
  Files         246      246              
  Lines       13200    13202       +2     
==========================================
+ Hits        10288    10291       +3     
  Misses       2390     2390              
+ Partials      522      521       -1     
Files Changed Coverage Δ
pkg/apis/feature/features.go 55.26% <0.00%> (-3.08%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karthikmurali60
Copy link
Contributor Author

@creydr I have made the necessary changes, can you please review this PR when you get a chance? Thanks !!

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, karthikmurali60

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@knative-prow knative-prow bot merged commit 2b02cb4 into knative:main Aug 17, 2023
24 of 28 checks passed
@karthikmurali60 karthikmurali60 deleted the add-oidc-auth branch October 5, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add authentication.oidc feature flag
2 participants