-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OIDC Authentication feature flag #7183
Conversation
Signed-off-by: karthikmurali60 <karthik.murali60@gmail.com>
|
Welcome @karthikmurali60! It looks like this is your first PR to knative/eventing 🎉 |
Hi @karthikmurali60. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7183 +/- ##
==========================================
+ Coverage 77.93% 77.95% +0.01%
==========================================
Files 246 246
Lines 13200 13202 +2
==========================================
+ Hits 10288 10291 +3
Misses 2390 2390
+ Partials 522 521 -1
☔ View full report in Codecov by Sentry. |
@creydr I have made the necessary changes, can you please review this PR when you get a chance? Thanks !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, karthikmurali60 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7174
Proposed Changes
Pre-review Checklist
Release Note
Docs