Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mt-broker-filter: reject request for wrong audience #7291

Closed
creydr opened this issue Sep 25, 2023 · 4 comments · Fixed by #7427
Closed

mt-broker-filter: reject request for wrong audience #7291

creydr opened this issue Sep 25, 2023 · 4 comments · Fixed by #7427
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Sep 25, 2023

As an implementation detail, we describe in https://gist.github.com/creydr/8b694956f27b0cb338b3576f3a893879, the broker filter gets its own dedicated Audience, named mt-broker-filter (in #7292 we will expose this audience in the Triggers Subscription as the subscribers audience).

When receiving an event, the mt-broker-filter receiver must:

Additional Information:

@creydr creydr added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 25, 2023
@xiangpingjiang
Copy link
Contributor

/assign

@Cali0707
Copy link
Member

Cali0707 commented Oct 31, 2023

Hey @xiangpingjiang any updates here? Is there anything I can help you with?

If you aren't interested in this issue anymore let me know so that someone else can work on it. Thanks!

@xiangpingjiang
Copy link
Contributor

hello, @Cali0707
I'm still interested in this issue, I will submit a pr this week. Thanks

@Cali0707
Copy link
Member

Great @xiangpingjiang - let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants