-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[control-plane]: Support exposing the Audience of a Broker #3520
Comments
@creydr I would like to work on this. |
Awesome. Just assign it to you via |
/triage accepted /assign @gunishmatta Thanks for picking this up @gunishmatta 🎉 |
@gunishmatta |
Hey @gunishmatta ! I hope you're doing well! We've noticed that there hasn't been much activity on this issue recently and we've missed your input. We just wanted to check in and see if everything is okay! I understand that life gets busy and priorities can shift. If you have already starting tackling this issue, that's great! Please let us know if you need any support. However, if you're tied up with other commitments, no worries at all - just give us a heads-up so we can release this issue to others who are eager to contribute too! Please let me know by commenting here within next 24 hours, otherwise I will be releasing this issue! |
Hi @Leo6Leo really sorry, got busy due to work commitments, I will raise a PR by this weekend. If this needs to be done before that then you can release this, else I will do |
Hey @gunishmatta No problem! Take you time. Looking forward to your PR! Don't hesitate to Let us know if you have any questions, and we are here to help :)) |
As the Eventing OIDC feature track describes, Addressables (and thus Brokers) need to announce their audience in
.status.address.audience
.In particular the EKB broker controller should:
authentication.oidc
feature flag knative/eventing#7174) is disabled:authentication.oidc
feature flag knative/eventing#7174) is enabled:.status.address.audience
accordingly.Additional Information:
The text was updated successfully, but these errors were encountered: