Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[control-plane]: Support exposing the Audience of a Broker #3520

Closed
creydr opened this issue Dec 8, 2023 · 7 comments · Fixed by #3600
Closed

[control-plane]: Support exposing the Audience of a Broker #3520

creydr opened this issue Dec 8, 2023 · 7 comments · Fixed by #3600
Assignees
Labels
area/control-plane help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Contributor

creydr commented Dec 8, 2023

As the Eventing OIDC feature track describes, Addressables (and thus Brokers) need to announce their audience in .status.address.audience.

In particular the EKB broker controller should:

Additional Information:

@creydr creydr added area/control-plane kind/TBD Parked issue that required triaging/revisit in a near future. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed kind/TBD Parked issue that required triaging/revisit in a near future. labels Dec 8, 2023
@gunishmatta
Copy link
Contributor

@creydr I would like to work on this.

@creydr
Copy link
Contributor Author

creydr commented Dec 12, 2023

@creydr I would like to work on this.

Awesome. Just assign it to you via /assign if you want to work on it and make sure you've gone through DEVELOPMENT.md as this contains helpful information on how to getting started.

@Cali0707
Copy link
Member

/triage accepted

/assign @gunishmatta

Thanks for picking this up @gunishmatta 🎉

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Dec 15, 2023
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Jan 5, 2024

@gunishmatta
Hey Gunish, are there anything we can help you with on this issue?

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Jan 10, 2024

Hey @gunishmatta ! I hope you're doing well! We've noticed that there hasn't been much activity on this issue recently and we've missed your input. We just wanted to check in and see if everything is okay!

I understand that life gets busy and priorities can shift. If you have already starting tackling this issue, that's great! Please let us know if you need any support. However, if you're tied up with other commitments, no worries at all - just give us a heads-up so we can release this issue to others who are eager to contribute too!

Please let me know by commenting here within next 24 hours, otherwise I will be releasing this issue!

@gunishmatta
Copy link
Contributor

Hi @Leo6Leo really sorry, got busy due to work commitments, I will raise a PR by this weekend.

If this needs to be done before that then you can release this, else I will do
Thanks

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Jan 10, 2024

Hey @gunishmatta No problem! Take you time. Looking forward to your PR! Don't hesitate to Let us know if you have any questions, and we are here to help :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants