Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-plane]: Kafka Broker receiver: reject requests for wrong audience #3574

Closed
creydr opened this issue Jan 9, 2024 · 1 comment
Closed
Labels
area/data-plane kind/TBD Parked issue that required triaging/revisit in a near future.

Comments

@creydr
Copy link
Contributor

creydr commented Jan 9, 2024

As the Eventing OIDC feature track describes, each Addressable gets its own Audience. Since #3520 the Audience of a Broker will be exposed in its status, so sources can create OIDC tokens dedicated for this Audience.

When receiving an event, the kafka-broker-receiver must:

  • when the feature flag (see Add authentication.oidc feature flag knative/eventing#7174) is disabled:
    • no change in behavior
  • when the feature flag is enabled:
    • when no / no valid Authorization header is provided
    • when a valid Authorization header is provided
      • check, if the provided OIDC tokens Audience aligns with the Brokers audience
        • If if does not align: decline the request with a 401
        • If it aligns: no change in behavior

Additional Information:

@creydr creydr changed the title [data-plane]: Broker Ingress: reject requests for wrong audience [data-plane]: Kafka Broker receiver: reject requests for wrong audience Jan 9, 2024
@creydr creydr added the kind/TBD Parked issue that required triaging/revisit in a near future. label Feb 8, 2024
@creydr
Copy link
Contributor Author

creydr commented Feb 9, 2024

Done in #3577

@creydr creydr closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-plane kind/TBD Parked issue that required triaging/revisit in a near future.
Projects
None yet
Development

No branches or pull requests

2 participants