Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto generation of Subscriptions identity service account and expose in AuthStatus #7223

Closed
creydr opened this issue Sep 5, 2023 · 7 comments · Fixed by #7338
Closed
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Sep 5, 2023

Problem

As the Eventing OIDC feature track describes, the AuthStatus is meant to provide the generated service account name in the resource status.

After #7173 is done, we should:

@creydr creydr added kind/TBD Parked issue that required triaging/revisit in a near future. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed kind/TBD Parked issue that required triaging/revisit in a near future. labels Sep 5, 2023
@aliok
Copy link
Member

aliok commented Sep 12, 2023

hi @creydr

I see you've added help-wanted label to this issue. If you think this is a good good-first-issue, can you:

  • Comment with /good-first-issue?
  • Add clear instructions (including code pointers) about how this issue can be resolved?

@creydr
Copy link
Member Author

creydr commented Sep 29, 2023

#7299 and #7316 show how this was done for the Trigger and could help to get started with this.

/good-first-issue

@knative-prow
Copy link

knative-prow bot commented Sep 29, 2023

@creydr:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

#7299 and #7316 show how this was done for the Trigger and could help to get started with this.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 29, 2023
@xiangpingjiang
Copy link
Contributor

/assign

@creydr
Copy link
Member Author

creydr commented Oct 5, 2023

Hello @xiangpingjiang,
Thanks for picking this 🎉
Do you have a rough ETA for a PR?

@xiangpingjiang
Copy link
Contributor

Hello @xiangpingjiang, Thanks for picking this 🎉 Do you have a rough ETA for a PR?

hello, @creydr

I will submit a PR next week

@creydr
Copy link
Member Author

creydr commented Oct 5, 2023

hello, @creydr

I will submit a PR next week

Awesome! Thanks for letting us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants