Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery Format: set kn-ingress-format ce extension in receiver #3969

Closed
Cali0707 opened this issue Jul 4, 2024 · 4 comments
Closed

Delivery Format: set kn-ingress-format ce extension in receiver #3969

Cali0707 opened this issue Jul 4, 2024 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jul 4, 2024

Problem
To support dispatching events from the Kafka based eventing components with the correct format when a user sets the spec.delivery.format to ingress, we need to set a cloudevent extension of kn-ingress-format to specify which format was used. This should be set to structured if the input event was structured, and binary if the input event was in binary. However, since this event may have been forwarded from earlier ingress, we need to only set the kn-ingress-format extension if it is not already present on the event.

Persona:
Which persona is this feature for?

Exit Criteria
Unit tests verifying that:

  1. If the extension is not present it is set correctly for both structured and binary events
  2. If the extension is already present, it is not changed for both structured and binary events

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/help

Copy link

knative-prow bot commented Jul 4, 2024

@Cali0707:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 4, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Jul 4, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 9, 2024

Given changes to the design of the feature, this is no longer needed

@Cali0707 Cali0707 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

1 participant