Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WaitForPodRunning instead of WaitForResourceReady #183

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Use WaitForPodRunning instead of WaitForResourceReady #183

merged 1 commit into from
Sep 17, 2020

Conversation

pierDipi
Copy link
Member

@pierDipi
Use WaitForPodRunning instead of WaitForResourceReady
3da3aee 
- #179
- #174
- #172
- #171

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2020
@pierDipi pierDipi mentioned this pull request Sep 17, 2020
Merged
@pierDipi
Copy link
Member Author

Worked, retesting
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@pierDipi
Copy link
Member Author

2/2
Worked, retesting
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

/assign @slinkydeveloper

@slinkydeveloper
Copy link
Contributor

@pierDipi since this tests was copied from eventing, can you propose the fix there too?

@pierDipi
Copy link
Member Author

@slinkydeveloper I planned to monitor them in continuous testing, and then propose it so that I'm sure what I'm proposing is the right thing to do, does that seem reasonable to you?

@pierDipi
Copy link
Member Author

3/3
Worked, retesting
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@pierDipi
Copy link
Member Author

4/4
Worked, retesting
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@pierDipi
Copy link
Member Author

5/5
Worked, retesting
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@slinkydeveloper
Copy link
Contributor

Sounds stable enough, let's merge it!

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@pierDipi
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@knative-prow-robot knative-prow-robot merged commit c32805f into knative-extensions:master Sep 17, 2020
@pierDipi pierDipi mentioned this pull request Sep 18, 2020
Closed
@pierDipi pierDipi deleted the use-wait-pods branch April 14, 2021 21:18
matzew pushed a commit to matzew/eventing-kafka-broker that referenced this pull request Apr 7, 2022
@openshift-cherrypick-robot @pierDipi
Include error in error message (knative-extensions#183)
35b5ba2 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harwayne Harwayne Awaiting requested review from Harwayne

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierDipi @slinkydeveloper @knative-prow-robot @googlebot