Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create cert manager resources for ekb components #3117

Merged
merged 4 commits into from
May 31, 2023
Merged

Create cert manager resources for ekb components #3117

merged 4 commits into from
May 31, 2023

Conversation

Cali0707
Copy link
Member

Fixes #3107

Proposed Changes

  • Add Cert-Manager resources for kafka-broker-receiver, kafka-channel-receiver, and kafka-sink-receiver

Release Note

Added Cert-Manager resources for the kafka-broker-receiver, kafka-channel-receiver, and kafka-sink-receiver.

@knative-prow knative-prow bot added area/data-plane size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2023
@Cali0707
Copy link
Member Author

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi May 30, 2023 17:46
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #3117 (b119414) into main (e45c5fe) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3117      +/-   ##
============================================
+ Coverage     63.41%   63.42%   +0.01%     
- Complexity      758      759       +1     
============================================
  Files           167      167              
  Lines         11356    11356              
  Branches        233      233              
============================================
+ Hits           7201     7203       +2     
+ Misses         3628     3627       -1     
+ Partials        527      526       -1
Flag Coverage Δ
java-unittests 81.35% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

pierDipi
pierDipi reviewed May 31, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

nit: missing copyright headers:

https://github.com/knative-sandbox/eventing-kafka-broker/blob/06e73351124a536eeb208f223e2b654b9a044dfa/control-plane/config/eventing-kafka-broker/200-controller/100-config-kafka-autoscaler.yaml#L1-L13

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2023
@Cali0707
Copy link
Member Author

Looks good!

nit: missing copyright headers:

https://github.com/knative-sandbox/eventing-kafka-broker/blob/06e73351124a536eeb208f223e2b654b9a044dfa/control-plane/config/eventing-kafka-broker/200-controller/100-config-kafka-autoscaler.yaml#L1-L13

Just added those

@Cali0707
Copy link
Member Author

/retest-required

pierDipi
pierDipi approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@knative-prow
Copy link

knative-prow bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@pierDipi
Copy link
Member

/retest-required

@knative-prow knative-prow bot merged commit 9e32247 into knative-extensions:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eventing TLS: Create Cert-Manager resources for EKB components
2 participants
@Cali0707 @pierDipi