Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed composite prober logic #3273

Merged

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Aug 4, 2023

Fixes #3262

Proposed Changes

  • Fix the status accumulation logic

Release Note

fixed the prober logic for addresses which could be http or https

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added area/control-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2023
@Cali0707
Copy link
Member Author

Cali0707 commented Aug 4, 2023

/cc @Leo6Leo @creydr

@knative-prow knative-prow bot requested review from creydr and Leo6Leo August 4, 2023 20:51
@Cali0707
Copy link
Member Author

Cali0707 commented Aug 4, 2023

This should fix the failing tests on #3267 #3261 and #3252

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #3273 (44c9e2f) into main (24ef5f8) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #3273      +/-   ##
============================================
+ Coverage     61.89%   61.91%   +0.02%     
- Complexity      765      766       +1     
============================================
  Files           181      181              
  Lines         12200    12200              
  Branches        268      268              
============================================
+ Hits           7551     7554       +3     
+ Misses         4061     4059       -2     
+ Partials        588      587       -1     
Flag Coverage Δ
java-unittests 72.12% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
control-plane/pkg/prober/composite_prober.go 78.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

@matzew
Copy link
Contributor

matzew commented Aug 8, 2023

/test channel-integration-tests-sasl-ssl

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@matzew
Copy link
Contributor

matzew commented Aug 8, 2023

/test channel-integration-tests-sasl-plain

@matzew
Copy link
Contributor

matzew commented Aug 8, 2023

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot merged commit a9b7d5f into knative-extensions:main Aug 8, 2023
20 of 22 checks passed
@Cali0707
Copy link
Member Author

Cali0707 commented Aug 8, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #3278

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite Prober causes finalizers to hang
3 participants