Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow consumergroup reconciliation under load #3293

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix slow consumergroup reconciliation under load #3293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@
condition.GetMessage(),
)

return fmt.Errorf("consumers aren't ready, %v: %v", condition.GetReason(), condition.GetMessage())
// It is "normal" to have non-ready consumers, and we will get notified when their status change,
// so we don't need to return an error here which causes the object to be queued with an
// exponentially increasing delay.
return nil

Check warning on line 67 in control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_lifecycle.go

View check run for this annotation

Codecov / codecov/patch

control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_lifecycle.go#L64-L67 

Added lines #L64 - L67 were not covered by tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explicit comment.

It seems reasonable

}

func (cg *ConsumerGroup) MarkReconcileConsumersSucceeded() {
Expand Down
3 changes: 1 addition & 2 deletions control-plane/pkg/reconciler/consumergroup/consumergroup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ func TestReconcileKind(t *testing.T) {
}, nil
}),
},
WantErr: true,
WantErr: false,
WantCreates: []runtime.Object{
NewConsumer(1,
ConsumerSpec(NewConsumerSpec(
Expand Down Expand Up @@ -465,7 +465,6 @@ func TestReconcileKind(t *testing.T) {
},
WantEvents: []string{
finalizerUpdatedEvent,
"Warning InternalError consumers aren't ready, ConsumerBinding: failed to bind resource to pod: EOF",
},
},
{
Expand Down
Loading