Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use triggerv2 controller in shared main #3558

Merged
merged 40 commits into from
Apr 3, 2024

fix: triggerv2 supports cg id templates

8b07dc2
Select commit
Loading
Failed to load commit list.
Merged

Use triggerv2 controller in shared main #3558

fix: triggerv2 supports cg id templates
8b07dc2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 3, 2024 in 0s

54.15% (+1.72%) compared to 648f4f0

View this Pull Request on Codecov

54.15% (+1.72%) compared to 648f4f0

Details

Codecov Report

Attention: Patch coverage is 38.23529% with 126 lines in your changes are missing coverage. Please review.

Project coverage is 54.15%. Comparing base (648f4f0) to head (8b07dc2).
Report is 23 commits behind head on main.

Files Patch % Lines
...md/post-install/kafka_broker_deployment_deleter.go 0.00% 27 Missing ⚠️
...ontrol-plane/pkg/reconciler/testing/statefulset.go 0.00% 26 Missing ⚠️
control-plane/cmd/post-install/main.go 0.00% 21 Missing ⚠️
control-plane/pkg/reconciler/consumer/consumer.go 34.37% 21 Missing ⚠️
control-plane/pkg/security/config.go 0.00% 8 Missing ⚠️
...l-plane/pkg/reconciler/broker/namespaced_broker.go 76.66% 3 Missing and 4 partials ⚠️
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go 82.85% 3 Missing and 3 partials ⚠️
...ane/pkg/reconciler/broker/namespaced_controller.go 0.00% 3 Missing ⚠️
control-plane/cmd/kafka-controller/main.go 0.00% 2 Missing ⚠️
control-plane/pkg/kafka/clientpool/clientpool.go 50.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3558      +/-   ##
============================================
+ Coverage     52.43%   54.15%   +1.72%     
- Complexity      874      875       +1     
============================================
  Files           342      346       +4     
  Lines         21415    18193    -3222     
  Branches        284      288       +4     
============================================
- Hits          11229     9853    -1376     
+ Misses         9276     7415    -1861     
- Partials        910      925      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov