Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Fix binary events with no data and ce overrides not being delivered #3580

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #3475

:bug: Fixed bug where binary events with no data were not delivered if cloud event overrides were enabled

Copy link

knative-prow bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2024
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9160b6) 58.45% compared to head (542437c) 58.45%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.11    #3580   +/-   ##
=============================================
  Coverage         58.45%   58.45%           
=============================================
  Files                91       91           
  Lines              9235     9235           
=============================================
  Hits               5398     5398           
  Misses             3410     3410           
  Partials            427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member

Cali0707 commented Jan 9, 2024

/cc @pierDipi

@Cali0707
Copy link
Member

Cali0707 commented Jan 9, 2024

/retest

1 similar comment
@Cali0707
Copy link
Member

/retest

Copy link

knative-prow bot commented Jan 10, 2024

@knative-prow-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing-kafka-broker_release-1.11 542437c link true /test unit-tests
channel-integration-tests-sasl-plain_eventing-kafka-broker_release-1.11 542437c link true /test channel-integration-tests-sasl-plain
reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.11 542437c link true /test reconciler-tests-namespaced-broker
integration-tests_eventing-kafka-broker_release-1.11 542437c link true /test integration-tests
channel-integration-tests-sasl-ssl_eventing-kafka-broker_release-1.11 542437c link true /test channel-integration-tests-sasl-ssl
channel-reconciler-tests-ssl_eventing-kafka-broker_release-1.11 542437c link true /test channel-reconciler-tests-ssl
reconciler-tests_eventing-kafka-broker_release-1.11 542437c link true /test reconciler-tests
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_release-1.11 542437c link true /test channel-reconciler-tests-sasl-plain
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_release-1.11 542437c link true /test channel-reconciler-tests-sasl-ssl
channel-integration-tests-ssl_eventing-kafka-broker_release-1.11 542437c link true /test channel-integration-tests-ssl
upgrade-tests_eventing-kafka-broker_release-1.11 542437c link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cali0707
Copy link
Member

Closing in favour of #3596

@Cali0707 Cali0707 closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-plane area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants