-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.11] Fix binary events with no data and ce overrides not being delivered #3580
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knative-prow-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
7230e64
to
542437c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #3580 +/- ##
=============================================
Coverage 58.45% 58.45%
=============================================
Files 91 91
Lines 9235 9235
=============================================
Hits 5398 5398
Misses 3410 3410
Partials 427 427 ☔ View full report in Codecov by Sentry. |
/cc @pierDipi |
/retest |
1 similar comment
/retest |
@knative-prow-robot: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing in favour of #3596 |
This is an automated cherry-pick of #3475