fix selector path for cg scale subresource

[Cali0707]

Currently, we don't define the scale subresource correctly on the consumergroup, as we say that the labelSelectorPath is .status.selector, while we set .spec.selector instead. See the code here:

eventing-kafka-broker/control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_defaults.go

Lines 41 to 43 in 6012e1b

	if cg.Spec.Selector == nil || len(cg.Spec.Selector) == 0 {
	cg.Spec.Selector = cg.Spec.Template.Labels
	}

I believe this should fix the "SelectorRequired" warnings we see on the scaled objects reported in knative/eventing#7655

Proposed Changes

• Set the .status.selector json path with the required values

Release Note

:bug: the scale subresource is now correctly defined for consumergroups

Docs

[Cali0707]

/cherry-pick release-1.13

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/cherry-pick release-1.12

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

/cc @converge

[knative-prow]

@pierDipi: GitHub didn't allow me to request PR reviews from the following users: converge.

Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @converge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6012e1b) 61.94% compared to head (7420dd9) 74.49%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #3666       +/-   ##
=============================================
+ Coverage     61.94%   74.49%   +12.54%     
- Complexity      845      846        +1     
=============================================
  Files           188       97       -91     
  Lines         12785     3207     -9578     
  Branches        273      273               
=============================================
- Hits           7920     2389     -5531     
+ Misses         4235      651     -3584     
+ Partials        630      167      -463     

Flag	Coverage Δ
java-unittests	74.49% <ø> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

/hold
Looks like I need to debug this change a bit more...

[Cali0707]

/unhold

The CI seems less flaky after the fix (or maybe I got lucky 🤷), maybe the incorrect scale subresource definition was also slowing things down on the API server side @pierDipi

[Cali0707]

/test reconciler-tests

[matzew]

/test reconciler-tests

[pierDipi]

/test reconciler-tests

[Cali0707]

/retest

[converge]

I have manually tested, and it works as expected! 🎉

HPA now shows the kafka lag value / target

[Cali0707]

/cc @pierDipi

[pierDipi]

/test reconciler-tests

[Cali0707]

/retest-required

[Cali0707]

/retest-required

[creydr]

Good catch @Cali0707!

/test reconciler-tests

[creydr]

/lgtm

Thanks for fixing @Cali0707

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707,creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Cali0707]

/retest-required

[Cali0707]

/retest-required

[pierDipi]

/test reconciler-tests-namespaced-broker

[creydr]

/retest-required

[knative-prow-robot]

@Cali0707: new pull request created: #3688

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@Cali0707: new pull request created: #3689

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.