Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from Beta to GA #3722

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

pierDipi
Copy link
Member

This component is GA for a long time already.

This component is GA.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.67%. Comparing base (fa11487) to head (76d29a2).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3722      +/-   ##
============================================
- Coverage     52.69%   52.67%   -0.02%     
+ Complexity      860      859       -1     
============================================
  Files           339      339              
  Lines         21087    21087              
  Branches        276      276              
============================================
- Hits          11112    11108       -4     
- Misses         9074     9075       +1     
- Partials        901      904       +3     
Flag Coverage Δ
java-unittests 74.52% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/cc @creydr @aliok

@knative-prow knative-prow bot requested review from aliok and creydr February 26, 2024 16:57
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
Copy link

knative-prow bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 955a886 into knative-extensions:main Feb 26, 2024
33 checks passed
@norbjd
Copy link

norbjd commented May 29, 2024

Hello @pierDipi,

I've just noticed that Knative documentation states that KafkaChannel is still in Beta despite this MR, is this an oversight? I can create the PR to update this file but I'd like to confirm with you before 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants