Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update eventing-kafka-broker-eventing nightly #3770

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Mar 18, 2024

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing f81f1d3...4ba426c:
  > 4ba426c [main] Upgrade to latest dependencies (# 7850)
  > 4139fdf [main] Update community files (# 7845)
  > 6585a2b [main] Upgrade to latest dependencies (# 7843)
  > f9d8dea [main] Upgrade to latest dependencies (# 7842)
  > d96c6db feat: add initial pathfinding algorithm (# 7782)
  > 1ed11b7 [e2e] fix ManyTriggers possible starvation of Setup features (# 7831)
  > cb538fc [main] Upgrade to latest dependencies (# 7835)
  > 0264d60 Remove sinkbindings OIDC token secret when not needed and fix status setting (# 7836)
  > 84115ea Map eventtypes into event lineage graph (# 7783)
  > c1611d5 Improve trust bundle propagation (# 7665)
  > 734c413 fix: install script picks up on platform architecture by default (# 7821)
  > ebb311d Remove eventing-kafka from downstream tests as it's deprecated (# 7826)
  > ce5b77f [main] Update community files (# 7828)
  > 1920235 CrossNamespace: updated namespace for subscription (# 7804)
  > 366afed ETs reference subscriptions/triggers on reply (# 7733)
  > 8069d71 [main] Upgrade to latest dependencies (# 7824)
  > 4cec554 [main] Upgrade to latest dependencies (# 7818)
  > 7e1c082 [main] Format Go code (# 7819)
  > e581d36 Update eventtype v1beta3 type to reflect spec changes (# 7708)
  > 93e0c85 CrossNamespace: added brokerRef in trigger spec (# 7815)
  > 4754325 [main] Update community files (# 7817)
  > ff32fbe Update DEVELOPMENT.md (# 7790)
  > 018bf31 [main] Upgrade to latest dependencies (# 7811)
  > 2aa8985 Adding broker namespace for triggers (# 7798)
  > 292e29c feat: add triggers to event lineage graph (# 7746)
  > 74803f8 [main] Upgrade to latest dependencies (# 7800)
  > 63068bd [main] Upgrade to latest dependencies (# 7794)
  > acc6385 [main] Update community files (# 7787)
  > c7db5cb Reduce the scope for the Config validation webhook to only the `knative-eventing` namespace. (# 7792)
  > 0604334 Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout (# 7786)
  > b644dad [main] Upgrade to latest dependencies (# 7785)
  > bbb9051 Fusion Hack  (# 7740)
  > e886832 [main] Upgrade to latest dependencies (# 7781)
  > 8a18b16 CrossNamespace: adding feature flag (# 7752)
  > 6f944bf Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (# 7750)

Copy link

knative-prow bot commented Mar 18, 2024

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative-extensions/eventing-wg-leads.

Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
 curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing f81f1d3...c7db5cb:
 > c7db5cb Reduce the scope for the Config validation webhook to only the `knative-eventing` namespace. (# 7792)
 > 0604334 Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout (# 7786)
 > b644dad [main] Upgrade to latest dependencies (# 7785)
 > bbb9051 Fusion Hack  (# 7740)
 > e886832 [main] Upgrade to latest dependencies (# 7781)
 > 8a18b16 CrossNamespace: adding feature flag (# 7752)
 > 6f944bf Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (# 7750)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.67%. Comparing base (551691c) to head (4cf2dcb).
Report is 11 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3770       +/-   ##
=============================================
- Coverage     73.90%   49.67%   -24.24%     
=============================================
  Files           100      246      +146     
  Lines          3407    14802    +11395     
  Branches        288        0      -288     
=============================================
+ Hits           2518     7353     +4835     
- Misses          716     6699     +5983     
- Partials        173      750      +577     
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-automation knative-automation force-pushed the update-nightly/eventing branch 4 times, most recently from 9c7fa89 to dae3e9f Compare March 25, 2024 11:05
@knative-automation knative-automation force-pushed the update-nightly/eventing branch 5 times, most recently from 0db9f1e to a67a4fa Compare April 1, 2024 11:06
@creydr
Copy link
Contributor

creydr commented Apr 2, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented Apr 3, 2024

/retest-required

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2024
@creydr
Copy link
Contributor

creydr commented Apr 3, 2024

/test reconciler-tests

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@pierDipi
Copy link
Member

pierDipi commented Apr 3, 2024

/retest-required

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@creydr
Copy link
Contributor

creydr commented Apr 4, 2024

/test reconciler-tests

1 similar comment
@creydr
Copy link
Contributor

creydr commented Apr 4, 2024

/test reconciler-tests

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

#3845 should help with some of the test failures

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/test integration-tests

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/retest-required

1 similar comment
@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/test reconciler-tests-namespaced-broker

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/test reconciler-tests

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

Seems upgrade tests are failing, because we're missing something like #3845 or knative/eventing#7733 (channel CRD updates) in 1.13
(at least locally I see in the eventing controller API Warning: unknown field \"spec.subscribers[0].name\")

Installed kafkachannel CRD during the up-/downgrade is from 2792efb (1.13 branch):

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  ...
  labels:
    app.kubernetes.io/version: 2792efb540c7de72d5330b3191ee1a4a385d07fa
    ...
  name: kafkachannels.messaging.knative.dev

@creydr
Copy link
Contributor

creydr commented Apr 22, 2024

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@knative-automation knative-automation force-pushed the update-nightly/eventing branch 2 times, most recently from ca02aaf to 73a5d91 Compare April 23, 2024 17:26
bumping knative.dev/eventing f81f1d3...4ba426c:
  > 4ba426c [main] Upgrade to latest dependencies (# 7850)
  > 4139fdf [main] Update community files (# 7845)
  > 6585a2b [main] Upgrade to latest dependencies (# 7843)
  > f9d8dea [main] Upgrade to latest dependencies (# 7842)
  > d96c6db feat: add initial pathfinding algorithm (# 7782)
  > 1ed11b7 [e2e] fix ManyTriggers possible starvation of Setup features (# 7831)
  > cb538fc [main] Upgrade to latest dependencies (# 7835)
  > 0264d60 Remove sinkbindings OIDC token secret when not needed and fix status setting (# 7836)
  > 84115ea Map eventtypes into event lineage graph (# 7783)
  > c1611d5 Improve trust bundle propagation (# 7665)
  > 734c413 fix: install script picks up on platform architecture by default (# 7821)
  > ebb311d Remove eventing-kafka from downstream tests as it's deprecated (# 7826)
  > ce5b77f [main] Update community files (# 7828)
  > 1920235 CrossNamespace: updated namespace for subscription (# 7804)
  > 366afed ETs reference subscriptions/triggers on reply (# 7733)
  > 8069d71 [main] Upgrade to latest dependencies (# 7824)
  > 4cec554 [main] Upgrade to latest dependencies (# 7818)
  > 7e1c082 [main] Format Go code (# 7819)
  > e581d36 Update eventtype v1beta3 type to reflect spec changes (# 7708)
  > 93e0c85 CrossNamespace: added brokerRef in trigger spec (# 7815)
  > 4754325 [main] Update community files (# 7817)
  > ff32fbe Update DEVELOPMENT.md (# 7790)
  > 018bf31 [main] Upgrade to latest dependencies (# 7811)
  > 2aa8985 Adding broker namespace for triggers (# 7798)
  > 292e29c feat: add triggers to event lineage graph (# 7746)
  > 74803f8 [main] Upgrade to latest dependencies (# 7800)
  > 63068bd [main] Upgrade to latest dependencies (# 7794)
  > acc6385 [main] Update community files (# 7787)
  > c7db5cb Reduce the scope for the Config validation webhook to only the `knative-eventing` namespace. (# 7792)
  > 0604334 Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout (# 7786)
  > b644dad [main] Upgrade to latest dependencies (# 7785)
  > bbb9051 Fusion Hack  (# 7740)
  > e886832 [main] Upgrade to latest dependencies (# 7781)
  > 8a18b16 CrossNamespace: adding feature flag (# 7752)
  > 6f944bf Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (# 7750)

Signed-off-by: Knative Automation <automation@knative.team>
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Copy link

knative-prow bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor

creydr commented Apr 24, 2024

/retest-required

1 similar comment
@creydr
Copy link
Contributor

creydr commented Apr 25, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented Apr 25, 2024

/test reconciler-tests

@knative-prow knative-prow bot merged commit 1a498ca into knative-extensions:main Apr 25, 2024
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants