fix: triggers use correct consumer group id generated from template

[Cali0707]

Currently, the triggers will always use a consumer group id generated from the default template. Instead, they should use the most up to date version of the template.

Proposed Changes

• Add a rekt test to test for regressions here
• Watch the configmap for changes

Release Note

:bug: triggers now correctly generate the consumer group id from the template, rather than just the default template

Docs

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.48%. Comparing base (edf8a50) to head (ed5f687).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3779      +/-   ##
============================================
+ Coverage     48.39%   52.48%   +4.09%     
- Complexity        0      877     +877     
============================================
  Files           243      343     +100     
  Lines         18044    21466    +3422     
  Branches          0      288     +288     
============================================
+ Hits           8732    11267    +2535     
- Misses         8574     9288     +714     
- Partials        738      911     +173     

Flag	Coverage Δ
java-unittests	73.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

/cc @matzew @pierDipi

[Cali0707]

/cc @maschmid

[Cali0707]

/cherry-pick release-1.13

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/cherry-pick release-1.12

[knative-prow-robot]

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matzew]

👍

[matzew]

/lgtm
/approve

/retest

[Cali0707]

Looks like that may have been a real failure

/cc @matzew

[Cali0707]

/retest-required

[matzew]

/retest

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@Cali0707: #3779 failed to apply on top of branch "release-1.13":

Applying: add rekt test to catch trigger cg being wrong
Using index info to reconstruct a base tree...
M	test/e2e_new/broker_sasl_ssl_test.go
M	test/rekt/features/broker_auth.go
Falling back to patching base and 3-way merge...
Auto-merging test/rekt/features/broker_auth.go
Auto-merging test/e2e_new/broker_sasl_ssl_test.go
CONFLICT (content): Merge conflict in test/e2e_new/broker_sasl_ssl_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add rekt test to catch trigger cg being wrong
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@Cali0707: #3779 failed to apply on top of branch "release-1.12":

Applying: add rekt test to catch trigger cg being wrong
Using index info to reconstruct a base tree...
M	test/e2e_new/broker_sasl_ssl_test.go
M	test/rekt/features/broker_auth.go
Falling back to patching base and 3-way merge...
Auto-merging test/rekt/features/broker_auth.go
Auto-merging test/e2e_new/broker_sasl_ssl_test.go
CONFLICT (content): Merge conflict in test/e2e_new/broker_sasl_ssl_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add rekt test to catch trigger cg being wrong
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

/cherry-pick release-1.13

[Cali0707]

/cherry-pick release-1.12

[knative-prow-robot]

@Cali0707: #3779 failed to apply on top of branch "release-1.13":

Applying: add rekt test to catch trigger cg being wrong
Applying: fix cm key name
Applying: fix: trigger controller now watches for changes to the config-kafka-features cm
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/trigger/controller.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/trigger/controller.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/trigger/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 fix: trigger controller now watches for changes to the config-kafka-features cm
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

@Cali0707: #3779 failed to apply on top of branch "release-1.12":

Applying: add rekt test to catch trigger cg being wrong
Using index info to reconstruct a base tree...
M	test/e2e_new/broker_sasl_ssl_test.go
M	test/rekt/features/broker_auth.go
Falling back to patching base and 3-way merge...
Auto-merging test/rekt/features/broker_auth.go
Auto-merging test/e2e_new/broker_sasl_ssl_test.go
CONFLICT (content): Merge conflict in test/e2e_new/broker_sasl_ssl_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add rekt test to catch trigger cg being wrong
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.