Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: triggers scale with KEDA #3813

Merged

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Apr 4, 2024

Fixes #3238

Proposed Changes

  • Refactor consumergroup scale checks to be more generic
  • Add a test that verifies that triggers scale up and down

Release Note

The kafka-broker-dispatcher StatefulSet now scales with KEDA if you enable the controller-autoscaler-keda feature flag

Docs

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot requested review from creydr and Leo6Leo April 4, 2024 19:15
@knative-prow knative-prow bot added area/test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Apr 4, 2024

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi April 4, 2024 19:17
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.93%. Comparing base (de17c00) to head (62eeb3a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3813   +/-   ##
=========================================
  Coverage     73.93%   73.93%           
- Complexity      875      876    +1     
=========================================
  Files           100      100           
  Lines          3407     3407           
  Branches        288      288           
=========================================
  Hits           2519     2519           
- Misses          714      715    +1     
+ Partials        174      173    -1     
Flag Coverage Δ
java-unittests 73.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
Copy link

knative-prow bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

pierDipi commented Apr 5, 2024

/retest-required

1 similar comment
@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit 0c5c2e5 into knative-extensions:main Apr 11, 2024
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Triggers autoscaling with KEDA
2 participants