Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.13] Bump sarma to 1.43.1 #3914

Merged
merged 1 commit into from
May 31, 2024
Merged

[release-1.13] Bump sarma to 1.43.1 #3914

merged 1 commit into from
May 31, 2024

Conversation

creydr
Copy link
Contributor

@creydr creydr commented May 31, 2024

Fixes #3909

Bumps sarma to 1.43.1 to address #3909 for 1.13.
Similar as #3911

/cc @pierDipi @fos1be

@knative-prow knative-prow bot requested a review from pierDipi May 31, 2024 06:02
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 31, 2024

@creydr: GitHub didn't allow me to request PR reviews from the following users: fos1be.

Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes #3909

Bumps sarma to 1.43.1 to address #3909 for 1.13.
Similar as #3911

/cc @pierDipi @fos1be

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2024
pierDipi
pierDipi approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor Author

creydr commented May 31, 2024

failed to wait for resources to be deleted: timed out waiting for the condition

/retest

@knative-prow knative-prow bot merged commit 8ec905a into knative-extensions:release-1.13 May 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creydr @pierDipi