Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed new trigger filters feature flag #3963

Merged

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jul 3, 2024

As part of moving the new trigger filters feature to GA, this PR removes the feature flag

Proposed Changes

  • Remove the feature flag

Release Note

The new-trigger-filters feature flag has been removed, and the feature is now GA.

Docs

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2024
@knative-prow knative-prow bot requested review from creydr and Leo6Leo July 3, 2024 20:04
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 3, 2024

/cc @pierDipi @creydr @matzew

/hold until the CE SDKs are updated

@knative-prow knative-prow bot requested a review from matzew July 3, 2024 20:04
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024
@knative-prow knative-prow bot requested a review from pierDipi July 3, 2024 20:04
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (d0df87a) to head (709015b).
Report is 17 commits behind head on main.

Files Patch % Lines
control-plane/pkg/reconciler/consumer/consumer.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3963      +/-   ##
============================================
+ Coverage     48.24%   52.83%   +4.59%     
- Complexity        0      856     +856     
============================================
  Files           246      344      +98     
  Lines         14500    17892    +3392     
  Branches          0      295     +295     
============================================
+ Hits           6995     9454    +2459     
- Misses         6799     7557     +758     
- Partials        706      881     +175     
Flag Coverage Δ
java-unittests 72.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/retest-required

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
Copy link

knative-prow bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit c56f86e into knative-extensions:main Jul 16, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants