[release-1.14] fix: kafka controller does not panic on invalid kafka client config #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
merged commit 12d1f32
into
knative-extensions:release-1.14
34 checks passed
pierDipi
pushed a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Jul 25, 2024
…client config (knative-extensions#4002) * fix: kafka controller does not panic on invalid kafka client config Signed-off-by: Calum Murray <cmurray@redhat.com> * fix: consumergroup configs are validated as non-nil Signed-off-by: Calum Murray <cmurray@redhat.com> --------- Signed-off-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Calum Murray <cmurray@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Jul 25, 2024
…client config (knative-extensions#4002) (#1134) * fix: kafka controller does not panic on invalid kafka client config * fix: consumergroup configs are validated as non-nil --------- Signed-off-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Calum Murray <cmurray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3938