Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unnecessary filter creations #4014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cali0707
Copy link
Member

The filters field is implicitly an AllFilter, which means that even if a user only creates a single filter two filters will get created. Similarly, if for some reason a user creates an all filter or any filter with only a single subfilter, we should not create the extra "wrapper" filter.

Proposed Changes

  • Only create an all or any filter if the filters list is > 1

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

knative-prow bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@Cali0707
Copy link
Member Author

/cc @pierDipi @Leo6Leo

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.25%. Comparing base (961961c) to head (949ac6e).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4014   +/-   ##
=======================================
  Coverage   48.25%   48.25%           
=======================================
  Files         246      246           
  Lines       14540    14540           
=======================================
  Hits         7016     7016           
  Misses       6817     6817           
  Partials      707      707           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member Author

/retest-required

@Cali0707
Copy link
Member Author

/cc @creydr @Leo6Leo

@knative-prow knative-prow bot requested a review from creydr August 12, 2024 14:20
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@pierDipi
Copy link
Member

/retest

@creydr
Copy link
Contributor

creydr commented Aug 26, 2024

/test upgrade-tests

2 similar comments
@creydr
Copy link
Contributor

creydr commented Aug 26, 2024

/test upgrade-tests

@creydr
Copy link
Contributor

creydr commented Aug 26, 2024

/test upgrade-tests

@creydr
Copy link
Contributor

creydr commented Aug 27, 2024

/retest

Copy link

knative-prow bot commented Aug 27, 2024

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_main 949ac6e link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@creydr
Copy link
Contributor

creydr commented Aug 30, 2024

@Cali0707 can you rebase this? It seems I can't push to your branch to rebase on my own :/

Changes should be like creydr@216fe89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants