Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] Expose OIDC audience of KafkaSink in its status #4073

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[release-1.15] Expose OIDC audience of KafkaSink in its status #4073

merged 2 commits into from
Aug 26, 2024

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Aug 20, 2024

Cherry-pick of #4067

Same as #4071 but fixes build issues

/cherry-pick release-1.14

@creydr
Expose OIDC audience of KafkaSink in its status (knative-extensions#4067
b0e9769 
)

* Provision audience of KafkaSink

* Add e2e test

* Run full OIDC e2e test suite

* run gofmt and goimports
@creydr
Fix build issue
4d88e72
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2024
@creydr
Copy link
Contributor Author

creydr commented Aug 20, 2024

/cc @pierDipi @matzew

@knative-prow knative-prow bot requested a review from matzew August 20, 2024 08:24
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.22%. Comparing base (d641892) to head (4d88e72).
Report is 1 commits behind head on release-1.15.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.15    #4073      +/-   ##
================================================
+ Coverage         48.17%   48.22%   +0.04%     
================================================
  Files               246      246              
  Lines             14585    14597      +12     
================================================
+ Hits               7027     7039      +12     
  Misses             6848     6848              
  Partials            710      710

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Contributor Author

creydr commented Aug 20, 2024

/test reconciler-tests-namespaced-broker

This was referenced Aug 20, 2024
Closed
Closed
pierDipi
pierDipi approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a7715ef into knative-extensions:release-1.15 Aug 26, 2024
36 of 37 checks passed
@knative-prow-robot
Copy link
Contributor

@creydr: new pull request created: #4082

In response to this:

Cherry-pick of #4067

Same as #4071 but fixes build issues

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 26, 2024
Merged
creydr added a commit to creydr/knative-eventing-kafka-broker that referenced this pull request Aug 26, 2024
@creydr
[release-1.15] Expose OIDC audience of KafkaSink in its status (knati…
cf44d3c 
…ve-extensions#4073)

* Expose OIDC audience of KafkaSink in its status (knative-extensions#4067)

* Provision audience of KafkaSink

* Add e2e test

* Run full OIDC e2e test suite

* run gofmt and goimports

* Fix build issue
creydr added a commit to creydr/knative-eventing-kafka-broker that referenced this pull request Sep 4, 2024
@creydr
[release-1.15] Expose OIDC audience of KafkaSink in its status (knati…
a0532b5 
…ve-extensions#4073)

* Expose OIDC audience of KafkaSink in its status (knative-extensions#4067)

* Provision audience of KafkaSink

* Add e2e test

* Run full OIDC e2e test suite

* run gofmt and goimports

* Fix build issue
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Sep 9, 2024
@creydr
[release-1.15] Expose OIDC audience of KafkaSink in its status (knati…
728b322 
…ve-extensions#4073) (#1166)

* Expose OIDC audience of KafkaSink in its status (knative-extensions#4067)

* Provision audience of KafkaSink

* Add e2e test

* Run full OIDC e2e test suite

* run gofmt and goimports

* Fix build issue
creydr added a commit to creydr/knative-eventing-kafka-broker that referenced this pull request Sep 10, 2024
@creydr
[release-1.15] Expose OIDC audience of KafkaSink in its status (knati…
cbada3f 
…ve-extensions#4073)

* Expose OIDC audience of KafkaSink in its status (knative-extensions#4067)

* Provision audience of KafkaSink

* Add e2e test

* Run full OIDC e2e test suite

* run gofmt and goimports

* Fix build issue
pierDipi pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Sep 12, 2024
@creydr
[release-1.15] Expose OIDC audience of KafkaSink in its status (knati…
12f81dc 
…ve-extensions#4073) (#1162)

* Expose OIDC audience of KafkaSink in its status (knative-extensions#4067)

* Provision audience of KafkaSink

* Add e2e test

* Run full OIDC e2e test suite

* run gofmt and goimports

* Fix build issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@creydr @knative-prow-robot @pierDipi