Create eventtypes on reply events to triggers and subscriptions

[Cali0707]

Fixes #4076
Fixes #4075

Proposed Changes

• Refactor the contract to have the feature flags available at the resource level, not on the ingress level.
• Handle autocreate on replies in the dispatcher
• Add an e2e test

Release Note

When eventtype autocreate is enabled, eventtypes are now created referencing subscriptions/triggers when there is a reply to the subscription/trigger

[Cali0707]

/cc @matzew

[pierDipi]

@creydr wondering if we should pass the full list here as a Map ? and perhaps call the field in Resource CoreFeatureFlags to distinguish between core config-features and Kafka ones config-kafka-features (in case we need them in the future)

[Cali0707]

I was thinking that would be good in the future, I just wasn't 100% sure about the approach so I decided to keep it minimal when starting on this PR. Happy to add the full set here/in a follow up PR if it makes sense

[creydr]

Having the full set could also help us on some OIDC stuff to get rid of the config-features CM mount point and watchers.

[creydr]

only one question from my side: is there a reason, why we would place it in the Resource message type, instead of at the top level on the Contract (similar to the trust bundles), as they should not really change between resources

[Cali0707]

This was because for EventType autocreate we sometimes want to disable it for a resource even when it is enabled. Specifically, if a channel is owned by a MTChannelBasedBroker, we should not create eventtypes on the channel as they will already be created by the broker

[pierDipi]

I like that additional flexibility on the resource level

[codecov]

Codecov Report

Attention: Patch coverage is 41.89189% with 43 lines in your changes missing coverage. Please review.

Project coverage is 48.42%. Comparing base (ba49d0f) to head (7192915).
Report is 2 commits behind head on main.

Files	Patch %	Lines
control-plane/pkg/contract/contract.pb.go	17.39%	37 Missing and 1 partial ⚠️
control-plane/pkg/reconciler/channel/channel.go	50.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4077      +/-   ##
==========================================
- Coverage   48.49%   48.42%   -0.07%     
==========================================
  Files         244      244              
  Lines       14712    14764      +52     
==========================================
+ Hits         7135     7150      +15     
- Misses       6866     6901      +35     
- Partials      711      713       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pierDipi]

/retest

[pierDipi]

/retest

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment