Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] Use v2 specific label to avoid matching previous deployment-based dispatchers #4105

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[release-1.15] Use v2 specific label to avoid matching previous deployment-based dispatchers #4105

merged 1 commit into from
Oct 2, 2024

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #4104

@pierDipi @knative-prow-robot
Use v2 specific label to avoid matching previous deployment-based dis…
ca97049 
…patchers

This ensures that our `consumergroup` controller as well as replication
controller only match v2-specific pods and won't try to reconcile
pods that belong to the previous deployment.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Sep 19, 2024
Merged
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.24%. Comparing base (a7715ef) to head (ca97049).
Report is 5 commits behind head on release-1.15.

Files with missing lines Patch % Lines
...ol-plane/pkg/reconciler/testing/objects_channel.go 0.00% 2 Missing ⚠️
...rol-plane/pkg/reconciler/testing/objects_source.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.15    #4105      +/-   ##
================================================
+ Coverage         48.22%   48.24%   +0.02%     
================================================
  Files               246      246              
  Lines             14597    14603       +6     
================================================
+ Hits               7039     7045       +6     
- Misses             6848     6849       +1     
+ Partials            710      709       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cali0707
Cali0707 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for catching and fixing this @pierDipi :)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@pierDipi
Copy link
Member

/retest-required

@creydr
Copy link
Contributor

creydr commented Sep 30, 2024

/test reconciler-tests-namespaced-broker

2 similar comments
@creydr
Copy link
Contributor

creydr commented Sep 30, 2024

/test reconciler-tests-namespaced-broker

@creydr
Copy link
Contributor

creydr commented Oct 1, 2024

/test reconciler-tests-namespaced-broker

@pierDipi
Copy link
Member

pierDipi commented Oct 2, 2024

/retest-required

@knative-prow knative-prow bot merged commit d1e6cb4 into knative-extensions:release-1.15 Oct 2, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knative-prow-robot @pierDipi @creydr @Cali0707