Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade to latest dependencies #4121

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[main] Upgrade to latest dependencies #4121

merged 2 commits into from
Oct 1, 2024

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Sep 30, 2024

Same as #4111 but fixing the build issues too

# knative.dev/eventing-kafka-broker/control-plane/pkg/reconciler/consumergroup
Error: control-plane/pkg/reconciler/consumergroup/consumergroup.go:452:51: not enough arguments in call to statefulSetScheduler.Schedule
	have (*"knative.dev/eventing-kafka-broker/control-plane/pkg/apis/internals/kafka/eventing/v1alpha1".ConsumerGroup)
	want ("context".Context, scheduler.VPod)

/cc @pierDipi

@knative-automation
upgrade to latest dependencies
05ecc3f 
bumping go.uber.org/automaxprocs e83e959...1ea14c3:
  > 1ea14c3 Release v1.6.0 (# 90)
  > 144f5c1 Remove glide.yaml (# 89)
  > 8553d3b Add option to round up CPU quota (# 79)
  > c9adbb9 Use Go 1.21 (# 82)
bumping google.golang.org/genproto/googleapis/rpc 573a115...ddb44da:
  > ddb44da chore: update to 1.21 (# 1152)
  > 8ffd90a chore(all): auto-regenerate .pb.go files (# 1150)
bumping github.com/gobuffalo/flect 6ae7779...cbe6b82:
  > cbe6b82 Merge pull request # 75 from khayyamsaleem/bugfix/74
  > 784c899 fix for panics when humanize called on whitespace
bumping google.golang.org/genproto/googleapis/api 573a115...ddb44da:
  > ddb44da chore: update to 1.21 (# 1152)
  > 8ffd90a chore(all): auto-regenerate .pb.go files (# 1150)
bumping knative.dev/pkg aaab500...5031733:
  > 5031733 Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0 (# 3097)
  > c4843b7 Give users the ability to disable namespace ownership of webhook configurations (# 3095)
  > 28b58b8 Use istio.sidecar.inject label instead of annotation (# 3096)
  > aabe552 Bump google.golang.org/grpc from 1.66.2 to 1.67.0 (# 3094)
  > a4774ed Bump github.com/gobuffalo/flect from 1.0.2 to 1.0.3 (# 3093)
bumping google.golang.org/grpc d0bf90a...6f50403:
  > 6f50403 Change version to 1.67.0 (# 7604)
  > 3c3a025 mem: replace flate.Reader reference (# 7595) (# 7637)
  > 3ffb98b .*: fix revive lints `redefines-builtin-id` (# 7552)
  > 5666049 vet: enforce revive linter (# 7589)
  > c6ad07f protoc: regenerate protos (# 7590)
  > 70f19ee credentials/tls: default GRPC_ENFORCE_ALPN_ENABLED to true (# 7535)
  > 92111dc xds: keep ads flow control local to xdsclient/transport package (# 7578)
  > 535bdce estats: remove dependency on testing package (# 7579)
  > 0f03c74 .*: fix revive lint issues `unused-parameter` (# 7580)
  > 6147c81 stats/opentelemetry: Optimize slice allocations (# 7525)
  > cd05c9e .*: fix revive package-comments lint issues (# 7574)
  > 00514a7 xds/clusterimpl: update UpdateClientConnState to handle updates synchronously (# 7533)
  > 093e099 grpc: fix regression by freeing request bufferslice after processing unary (# 7571)
  > 8320224 .*: revive from unused_parameters (# 7577)
  > 845f62c stats/otel: upgrade grpc version that contains the experimental/stats package (# 7545)
  > 55d820d clusterresolver/e2e_test: Avoid making DNS requests (# 7561)
  > 52961f7 grpc: add docs for generic stream interfaces  (# 7470)
  > 005b092 examples/advancedtls: example code for different security configurations for grpc-go using `advancedtls` (# 7474)
  > 0b6f354 xdsclient: Populate total_issued_requests count in LRS load reports (# 7544)
  > c535946 grpc: Fix flaky picker_wrapper tests (# 7560)
  > 9feed00 balancer/wrr: prefer calling Equal() method of time.Time (# 7529)
  > a8e6e11 .*: Use `strings.ReplaceAll(.....)` (# 7554)
  > 6d97688 xds/xdsclient: Fix flaky test TestLRSClient  (# 7559)
  > cfd14ba encoding: delete v1 proto codec and use one map for registry (# 7557)
  > 3d95421 Fix revive identified linter issues: var-declaration, indent-error-flow, increment-decrement, superfluous-else (# 7528)
  > e4b09f1 Remove trailing whitespace in testing.yml (# 7551)
  > 0a5b8f7 balancer: disallow producer streams until SubConn has reported READY (# 7523)
  > 9ab8b62 Implement new Codec that uses `mem.BufferSlice` instead of `[]byte` (# 7356)
  > 7e12068 bootstrap: add `String` method to ServerConfigs type (# 7537)
  > ee5cbce ringhash: fix bug where ring hash can be stuck in transient failure despite having available endpoints (# 7364)
  > 1e2bb71 doc: update keepalive ClientParameters doc about doubling the interval upon GOAWAY (# 7469)
  > 6a5a283 Use builtin min and max functions (# 7478)
  > 90caeb3 deps: update dependencies for all modules (# 7531)
  > f8d98a4 rbac: fix usage of AuthInfo (# 7522)
  > 4e29cc6 transport: add timeout for writing GOAWAY on http2Client.Close() (# 7371)
  > b45fc41 Change version to 1.67.0-dev (# 7520)
bumping knative.dev/eventing 1708881...e7fca76:
  > e7fca76 Add Istio inject label (# 8205)
  > 641cbb7 Remove scheduler `wait`s to speed up recovery time (# 8200)
  > 2869c6c Enhance tests for v1b3 event type, new attrs (# 8197)
bumping knative.dev/reconciler-test 0cb8938...87d8570:
  > 87d8570 Use istio inject label (# 762)
  > 1fee6ba upgrade to latest dependencies (# 758)
  > 13c0118 Handle resource already exists in Apply (# 759)

Signed-off-by: Knative Automation <automation@knative.team>
@creydr
Fix build issues
d30bb4b
@knative-prow knative-prow bot added area/control-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2024
@creydr creydr mentioned this pull request Sep 30, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.47%. Comparing base (e3ede63) to head (d30bb4b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4121   +/-   ##
=======================================
  Coverage   48.47%   48.47%           
=======================================
  Files         244      244           
  Lines       14888    14888           
=======================================
  Hits         7217     7217           
  Misses       6943     6943           
  Partials      728      728

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Contributor Author

creydr commented Sep 30, 2024

/retest

pierDipi
pierDipi approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@pierDipi
Copy link
Member

pierDipi commented Oct 1, 2024

/test reconciler-tests-namespaced-broker

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor Author

creydr commented Oct 1, 2024

/test reconciler-tests-namespaced-broker

1 similar comment
@creydr
Copy link
Contributor Author

creydr commented Oct 1, 2024

/test reconciler-tests-namespaced-broker

@creydr
Copy link
Contributor Author

creydr commented Oct 1, 2024

/retest

@creydr
Copy link
Contributor Author

creydr commented Oct 1, 2024

/test reconciler-tests

@knative-prow knative-prow bot merged commit babaf65 into knative-extensions:main Oct 1, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@creydr @pierDipi @knative-automation