Improve data-plane pods annotation update logic #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
approved
pierDipi
force-pushed
the
update-data-plane=pods-annotation-improvement
branch
from
5528958
to
21778e7
Compare
Codecov Report
@@ Coverage Diff @@
## main #999 +/- ##
============================================
- Coverage 75.60% 75.25% -0.35%
- Complexity 417 420 +3
============================================
Files 73 74 +1
Lines 2906 2914 +8
Branches 124 124
============================================
- Hits 2197 2193 -4
- Misses 556 564 +8
- Partials 153 157 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There could be situations where our reconciler failed to update a pod annotation in a previous reconcile and since there might be multiple pods running we want to make sure that all pods have the same annotation. This patch moves the logic to check that we're not performing an unnecessary update down to when we're trying to update a single pod annotation. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi
force-pushed
the
update-data-plane=pods-annotation-improvement
branch
from
21778e7
to
b36a40e
Compare
|
The following is the coverage report on the affected files.
|
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matzew
pushed a commit
to matzew/eventing-kafka-broker
that referenced
this pull request
Mar 5, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
matzew
pushed a commit
to matzew/eventing-kafka-broker
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Apr 29, 2024
…ions#1065) Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be situations where our reconciler failed to update a pod annotation
in a previous reconcile and since there might be multiple pods running we
want to make sure that all pods have the same annotation.
This patch moves the logic to check that we're not performing an
unnecessary update down to when we're trying to update a single pod
annotation.
Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com