-
Notifications
You must be signed in to change notification settings - Fork 82
[KafkaChannels] Pass-through "additional headers" #1001
[KafkaChannels] Pass-through "additional headers" #1001
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 74.69% 74.74% +0.04%
==========================================
Files 121 121
Lines 5675 5693 +18
==========================================
+ Hits 4239 4255 +16
- Misses 1213 1215 +2
Partials 223 223
Continue to review full report at Codecov.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, travis-minke-sap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The common
MessageReceiver
implementation forwards "additional headers" to the registered handler. These are non-ce headers that are deemed important to pass-through (x-b3, etc). Currently the KafkaChannel implementations do not forward these headers. Not forwarding such headers can, as an example, limit the ability to perform complete e2e tracing in Istio.Proposed Changes
ProducerMessage.Headers
ConsumerMessage.Headers
Release Note