Skip to content

Commit

Permalink
set defaults is taking care so the namespace does not get empty, so t…
Browse files Browse the repository at this point in the history
…his should be good enough to pass
  • Loading branch information
gabo1208 committed Jun 27, 2023
1 parent c7cf823 commit 8af3a2b
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions pkg/reconciler/trigger/trigger.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,14 +269,6 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, t *eventingv1.Trigger) p
logging.FromContext(ctx).Info("Reconciled rabbitmq binding", zap.Any("binding", binding))
t.Status.MarkDependencySucceeded()

if t.Spec.Subscriber.Ref != nil {
// To call URIFromDestination(dest apisv1alpha1.Destination, parent interface{}), dest.Ref must have a Namespace
if t.Spec.Subscriber.Ref.Namespace == "" {
// We will use the Namespace of Trigger as the Namespace of dest.Ref if one is not provided
t.Spec.Subscriber.Ref.Namespace = t.GetNamespace()
}
}

subscriberURI, err := r.uriResolver.URIFromDestinationV1(ctx, t.Spec.Subscriber, t)
if err != nil {
logging.FromContext(ctx).Error("Unable to get the Subscriber's URI", zap.Error(err))
Expand Down

0 comments on commit 8af3a2b

Please sign in to comment.