-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource.[requests|limits]
to reconciled objects
#703
Comments
cc @gabo1208 if we can get the resource requirements for when the performance tests were run, that could be a good baseline for the limit |
Sure but you mean the ones defined on the files, totals of the cluster or anything else? |
Just for the ingress/dispatcher pods. The cluster requirements can be customized by users already but we'd need sane values for the ingress and dispatcher pods |
/assign |
For setting the current limits in the Dispatcher, Adapter:
and Ingress:
Env: We used the performance tests as indicators, and divided them into three cases:
|
Problem
Skimming through the
reconciler
codebase/folders, it seems that none of the deployments/pods created have anyresources
specified. This can lead to performance and stability issues, especially not meeting the documented scaling behavior (#408).Persona:
Operators and users.
Exit Criteria
Documented scaling limits (benchmarks) are met even when deploying the resources in a constrained (overutilized) cluster.
Time Estimate (optional):
Implementation is straightforward (add
requests
and/orlimits
), but finding the right values might take time (in benchmarks).Additional context (optional)
Even without benchmarking, adding sane defaults (at least
requests
) should be done for the various reconciled resources.cc/ @salaboy @gabo1208
The text was updated successfully, but these errors were encountered: