Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates resource limits for source controller #738

Merged
merged 1 commit into from
May 3, 2022

Conversation

gab-satchi
Copy link
Contributor

  • 🧹 Removes limit set on resources
  • 🧹 Sets requests to 100m cpu and 100Mi memory

/kind enhancement

20-30Mi is too little for a controller. With these changes, this controller will be in line with the broker controller along with eventing-core controller. Users can still modify this value before installing and can also apply limits should they wish.

Release Note

- resource requests for source controller increased

Related to #703

@knative-prow knative-prow bot added kind/enhancement size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #738 (0f7b21d) into main (5a2cfc9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   74.73%   74.73%           
=======================================
  Files          35       35           
  Lines        2569     2569           
=======================================
  Hits         1920     1920           
  Misses        582      582           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2cfc9...0f7b21d. Read the comment docs.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@knative-prow
Copy link

knative-prow bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b6280be into knative-extensions:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants