Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: update github.com/rabbitmq/amqp091-go from 1.3.0 to 1.8.1 #1142

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Jun 27, 2023

Changes

  • 🧹 cleanup: update github.com/rabbitmq/amqp091-go from 1.3.0 to 1.8.1

1.3.0 was released on jan 13, 2022
1.8.1 was released on may 4, 2023

/kind cleanup

Fixes #

Release Note

cleanup: update github.com/rabbitmq/amqp091-go from 1.3.0 to 1.8.1

Docs


@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1142 (794179c) into main (23b6dd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1142   +/-   ##
=======================================
  Coverage   74.18%   74.18%           
=======================================
  Files          44       44           
  Lines        3304     3304           
=======================================
  Hits         2451     2451           
  Misses        764      764           
  Partials       89       89           

@k4leung4 k4leung4 changed the title cleanup: update github.com/rabbitmq/amqp091-go to 1.8.1 from 1.3.0 cleanup: update github.com/rabbitmq/amqp091-go from 1.3.0 to 1.8.1 Jun 27, 2023
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@gabo1208
Copy link
Contributor

just the style error and it's good to go!

@k4leung4
Copy link
Contributor Author

just the style error and it's good to go!

thanks, the style is all in the vendor path, which i cant modify
not sure why it is not ignoring those files

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, k4leung4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@gabo1208
Copy link
Contributor

cc @pierDipi @dprotaso @kvmware We don't know why those checks are failing in the vendor directory

@knative-extensions knative-extensions deleted a comment from knative-prow bot Jun 29, 2023
@dprotaso
Copy link
Contributor

/override "style / suggester / shell"

@knative-prow
Copy link

knative-prow bot commented Jun 29, 2023

@dprotaso: Overrode contexts on behalf of dprotaso: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit e5d3ca7 into knative-extensions:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants