Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved readbinary method #1153

Merged

Conversation

gabo1208
Copy link
Contributor

@gabo1208 gabo1208 commented Jun 30, 2023

Changes

  • Now the ingress errors using the ReadBinary method should be always the same

/kind enhancement

Fixes #1152

Release Note

- Now the ingress errors using the ReadBinary method should be always the same

@knative-prow
Copy link

knative-prow bot commented Jun 30, 2023

@gabo1208: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from aliok and creydr June 30, 2023 13:20
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1153 (9186017) into main (680e89f) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

❗ Current head 9186017 differs from pull request most recent head 2048453. Consider uploading reports for the commit 2048453 to get more accurate results

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   74.31%   74.28%   -0.03%     
==========================================
  Files          44       44              
  Lines        3309     3306       -3     
==========================================
- Hits         2459     2456       -3     
  Misses        762      762              
  Partials       88       88              
Impacted Files Coverage Δ
pkg/rabbit/message.go 77.33% <57.14%> (-0.45%) ⬇️

@gabo1208 gabo1208 force-pushed the same-error-converting-events branch from 12cbd5d to 9186017 Compare June 30, 2023 14:22
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2023
@krsna-m
Copy link

krsna-m commented Jul 10, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@knative-prow knative-prow bot merged commit e2d3ab0 into knative-extensions:main Jul 10, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random broker ingress behaviour when receiving binary format
2 participants