Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to readme (use source). Instruct KO to build and push t… #1168

Merged

Conversation

thomasjohansen
Copy link
Contributor

@thomasjohansen thomasjohansen commented Jul 13, 2023

…o local repo, and import the images into kind

Changes

🎁 Added Apple Silicon support for tests
🐛 Always compile cmd's and use them for tests

/kind bug
/kind documentation
/kind enhancement

Release Note

Tests are now running nativly on Apple Silicon.
Ko builds cmd's images and push them to local repo. Images are imported into kind.
Use source when setting up the test environment.

…o local repo, and import the images into kind
@knative-prow
Copy link

knative-prow bot commented Jul 13, 2023

@thomasjohansen: The label(s) kind/bug,, kind/documentation, cannot be applied, because the repository doesn't have them.

In response to this:

…o local repo, and import the images into kind

Changes

🎁 Added Apple Silicon support for tests
🐛 Always compile cmd's and use them for tests

/kind bug, documentation, enhancement

Release Note

Tests are now running nativly on Apple Silicon.
Ko builds cmd's images and push them to local repo. Images are imported into kind.
Use source when setting up the test environment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2023
@knative-prow knative-prow bot requested review from creydr and krsna-m July 13, 2023 20:23
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
Makefile Outdated
$(KUBECTL) wait --for=condition=available deploy/rabbitmq-broker-controller --timeout=60s --namespace $(EVENTING_NAMESPACE)
$(KUBECTL) wait --for=condition=available deploy/rabbitmq-broker-webhook --timeout=60s --namespace $(EVENTING_NAMESPACE)
$(KO) apply --filename config/source
$(KO) apply --local --platform=linux/amd64,linux/arm64 --filename config/source && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need this, ko apply already does what we need, sure this does not work on m1 macs without this line?

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1168 (f1d6272) into main (c43e8e7) will increase coverage by 0.08%.
Report is 15 commits behind head on main.
The diff coverage is n/a.

❗ Current head f1d6272 differs from pull request most recent head 32c0f83. Consider uploading reports for the commit 32c0f83 to get more accurate results

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   74.50%   74.59%   +0.08%     
==========================================
  Files          44       44              
  Lines        3303     3417     +114     
==========================================
+ Hits         2461     2549      +88     
- Misses        756      767      +11     
- Partials       86      101      +15     

see 8 files with indirect coverage changes

using conditional recipes
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, thomasjohansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@knative-prow knative-prow bot merged commit 62ed543 into knative-extensions:main Aug 1, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants