-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes to readme (use source). Instruct KO to build and push t… #1168
Minor changes to readme (use source). Instruct KO to build and push t… #1168
Conversation
…o local repo, and import the images into kind
@thomasjohansen: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Makefile
Outdated
$(KUBECTL) wait --for=condition=available deploy/rabbitmq-broker-controller --timeout=60s --namespace $(EVENTING_NAMESPACE) | ||
$(KUBECTL) wait --for=condition=available deploy/rabbitmq-broker-webhook --timeout=60s --namespace $(EVENTING_NAMESPACE) | ||
$(KO) apply --filename config/source | ||
$(KO) apply --local --platform=linux/amd64,linux/arm64 --filename config/source && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need this, ko apply already does what we need, sure this does not work on m1 macs without this line?
Codecov Report
@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
+ Coverage 74.50% 74.59% +0.08%
==========================================
Files 44 44
Lines 3303 3417 +114
==========================================
+ Hits 2461 2549 +88
- Misses 756 767 +11
- Partials 86 101 +15 |
f1d6272
to
32c0f83
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabo1208, thomasjohansen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…o local repo, and import the images into kind
Changes
🎁 Added Apple Silicon support for tests
🐛 Always compile cmd's and use them for tests
/kind bug
/kind documentation
/kind enhancement
Release Note