Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hard reset conditions to RabbitMQ connections in the Adapter and Dispatcher #1215

Merged

Conversation

gabo1208
Copy link
Contributor

@gabo1208 gabo1208 commented Sep 1, 2023

fixes #1175 #1214

Changes

  • 🎁 Added hard reset directives to the RabbitMQ connections, so the pods restart whenever the soft resets fails too many times, so the whole system status is clear for the user and some other edge cases are solved by just restarting every pod that needs a connection to the RabbitMQ Cluster

/kind enhancement

Release Note

🎁 Added hard reset directives to the RabbitMQ connections, so the pods restart whenever the soft resets fails too many times, so the whole system status is clear for the user and some other edge cases are solved by just restarting every pod that needs a connection to the RabbitMQ Cluster

@knative-prow
Copy link

knative-prow bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1215 (7eb8c10) into main (fe20e12) will increase coverage by 0.04%.
Report is 4 commits behind head on main.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
+ Coverage   74.59%   74.64%   +0.04%     
==========================================
  Files          44       44              
  Lines        3417     3427      +10     
==========================================
+ Hits         2549     2558       +9     
  Misses        768      768              
- Partials      100      101       +1     
Files Changed Coverage Δ
pkg/adapter/adapter.go 61.68% <0.00%> (ø)
pkg/rabbit/connections_handler.go 82.70% <82.35%> (+0.59%) ⬆️

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2023
…fter 5 soft retries, now the state of the whole thing is clear to the user
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2023
@gabo1208 gabo1208 changed the title [DRAFT] kill the pod when the soft reconnection tries fails so everything rec… Added hard reset conditions to RabbitMQ connections in the Adapter and Dispatcher Sep 3, 2023
@krsna-m
Copy link

krsna-m commented Sep 6, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@knative-prow knative-prow bot merged commit 91833fb into knative-extensions:main Sep 6, 2023
21 checks passed
@gabo1208
Copy link
Contributor Author

gabo1208 commented Sep 7, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link

@gabo1208: new pull request created: #1222

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispatcher taking ~10min to reconnect after being disconnected
3 participants