Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode broker class that the broker operates on #512

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Nov 16, 2021

closes #466

Changes

  • 🗑️ Do not expose the broker class that the controller operates on as an environment variable.

/kind removal

Release Note

Do not  expose the broker class that the controller operates on as an environment variable.

@knative-prow-robot knative-prow-robot added the kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. label Nov 16, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 16, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #512 (9f85739) into main (fa57fe2) will increase coverage by 0.05%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   75.80%   75.85%   +0.05%     
==========================================
  Files          45       45              
  Lines        2711     2717       +6     
==========================================
+ Hits         2055     2061       +6     
  Misses        533      533              
  Partials      123      123              
Impacted Files Coverage Δ
pkg/apis/eventing/v1/trigger_validation.go 54.54% <ø> (ø)
pkg/reconciler/trigger/controller.go 73.43% <50.00%> (ø)
pkg/reconciler/broker/controller.go 97.05% <100.00%> (ø)
pkg/reconciler/brokerstandalone/controller.go 96.29% <100.00%> (ø)
pkg/apis/sources/v1alpha1/rabbitmq_types.go 50.00% <0.00%> (ø)
pkg/reconciler/source/resources/receive_adapter.go 100.00% <0.00%> (ø)
pkg/adapter/adapter.go 66.48% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa57fe2...9f85739. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@benmoss
Copy link
Contributor

benmoss commented Nov 18, 2021

/lgtm
/approve

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, gabo1208, ikvmw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@knative-prow-robot knative-prow-robot merged commit d221028 into knative-extensions:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker class shouldn't be configurable
4 participants