Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring messages sent into the RabbitMQ CRDs to be Persistent #560

Conversation

gabo1208
Copy link
Contributor

@gabo1208 gabo1208 commented Jan 3, 2022

Changes

  • 🎁 Configuring messages sent into the RabbitMQ CRDs to be Persistent

/kind bug

Fixes #546

Release Note

- Configuring messages sent into the RabbitMQ Broker's to be persistent as the Queues used by the Broker's are always durable
- Now if the user set the configuration of the RabbitMQ Source Exchange and Queue to be durable the messages are also durable

Docs

@knative-prow-robot knative-prow-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2022
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #560 (063d166) into main (06ba8e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files          47       47           
  Lines        2892     2892           
=======================================
  Hits         2186     2186           
  Misses        568      568           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06ba8e7...063d166. Read the comment docs.

@benmoss
Copy link
Contributor

benmoss commented Jan 10, 2022

/lgtm
/approve

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2022
@knative-prow-robot knative-prow-robot merged commit 3cf5b9c into knative-extensions:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent messages
3 participants