Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put together short testing guide, .env -> (direnv friendly).envrc #599

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Put together short testing guide, .env -> (direnv friendly).envrc #599

merged 1 commit into from
Feb 1, 2022

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Jan 31, 2022

Changes

  • 🧹 Put together short testing guide, .env -> (direnv friendly).envrc

/kind documentation
/kind cleanup

Release Note

Put together short testing guide, .env -> (direnv friendly).envrc

@knative-prow-robot knative-prow-robot added kind/documentation kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022 •
edited
Loading

Codecov Report

Merging #599 (1d95766) into main (dcf9a44) will not change coverage.
The diff coverage is n/a.

❗ Current head 1d95766 differs from pull request most recent head f354f00. Consider uploading reports for the commit f354f00 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   75.06%   75.06%           
=======================================
  Files          47       47           
  Lines        2883     2883           
=======================================
  Hits         2164     2164           
  Misses        581      581           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf9a44...f354f00. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2022
@knative-prow-robot knative-prow-robot merged commit 1b77031 into knative-extensions:main Feb 1, 2022
gabo1208
gabo1208 suggested changes Feb 1, 2022
View reviewed changes
test/README.md
```

Here we create our environment file containing patched PATH, various exports, etc.
I personally like to use [direnv](https://direnv.net/) too. It will pick up .envrc and source it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try not to use personal pronouns or appreciations, we could use something like "it is compatible with direnv..."

test/README.md
make kind-cluster
```

This will install `kind` to ./bin and initialize the cluster. Kind uses [kind.yaml](e2e/kind.yaml) as cluster configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will install `kind` to ./bin and initialize the cluster. Kind uses [kind.yaml](e2e/kind.yaml) as cluster configuration.
This will install `kind` to the `./bin` directory and initialize the cluster. Kind uses [kind.yaml](e2e/kind.yaml) as cluster configuration.

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ikvmw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabo1208 gabo1208 gabo1208 requested changes

@xtreme-sameer-vohra xtreme-sameer-vohra Awaiting requested review from xtreme-sameer-vohra

Assignees

@gabo1208 gabo1208

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikavgo @knative-prow-robot @gabo1208